From: Jan Kara <jack@suse.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, greg.freemyer@gmail.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] ext3: Add batched discard support for ext3
Date: Wed, 24 Nov 2010 17:35:43 +0100 [thread overview]
Message-ID: <20101124163543.GV6113@quack.suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1011241555190.3293@dhcp-lab-213.englab.brq.redhat.com>
On Wed 24-11-10 15:56:33, Lukas Czerner wrote:
> On Wed, 24 Nov 2010, Jan Kara wrote:
> > + if (err < 0) {
> > + if (err != -EOPNOTSUPP)
> > + ext3_warning(sb, __func__, "Discard command "
> > + "returned error %d\n", err);
>
> Maybe we can remove this warning completely and let use-space utility
> handle and print out error message ?
We could but at this point something strange is happening (ENOMEM, EIO,
or something like that) so issuing a warning makes some sense. So I'd be
maybe slightly in favor of keeping the warning.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-11-24 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 13:06 [PATCH 0/2] Ext3 discard support Jan Kara
2010-11-24 13:06 ` [PATCH 1/2] ext3: Add batched discard support for ext3 Jan Kara
2010-11-24 14:56 ` Lukas Czerner
2010-11-24 16:35 ` Jan Kara [this message]
2010-11-25 14:27 ` Lukas Czerner
2010-11-25 18:29 ` Andreas Dilger
2010-11-26 8:01 ` Lukas Czerner
2010-11-26 10:33 ` Andreas Dilger
2011-01-06 14:26 ` Jan Kara
2010-11-24 13:06 ` [PATCH 2/2] ext3: Add FITRIM handling Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2010-11-22 11:29 [PATCH 1/2] ext3: Add batched discard support for ext3 Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124163543.GV6113@quack.suse.cz \
--to=jack@suse.cz \
--cc=greg.freemyer@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).