From: Ted Ts'o <tytso@mit.edu>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: Jonathan Nieder <jrnieder@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: Bug#605009: serious performance regression with ext4
Date: Mon, 29 Nov 2010 10:37:02 -0500 [thread overview]
Message-ID: <20101129153702.GB7994@thunk.org> (raw)
In-Reply-To: <201011291618.25084.bernd.schubert@fastmail.fm>
On Mon, Nov 29, 2010 at 04:18:24PM +0100, Bernd Schubert wrote:
>
> Wouldn't it make sense to modify ext4 or even the vfs to do that on
> close() itself? Most applications expect the file to be on disk
> after a close anyway and I also don't see a good reason why one
> should delay a disk write-back after close any longer (well, there
> are exeption if the application is broken, for example such as
> ha-logd used by pacemaker, which did for each line of logs an open,
> seek, write, flush, close sequence..., but at least we have fixed
> that in -hg now).
I can think of plenty of cases where it wouldn't make sense to do that
on a close(). For example, it would dramatically slow down compiles.
Just to give one example, you really don't want to force writeback to
start when the compiler finishes writing an intermediate .o file. And
there are often temporary files which are created and then deleted
very shortly afterwards; forcing writeback just because the file has
been closed would be pointless.
Now, a hint that could be set via an open flag, or via fcntl(), saying
that *this* file is one that should really be written at close() time
--- that would probably be a good idea, if application/library authors
would actually use it.
- Ted
next prev parent reply other threads:[~2010-11-29 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101126093257.23480.86900.reportbug@pluto.milchstrasse.xx>
[not found] ` <20101126145327.GB19399@rivendell.home.ouaza.com>
[not found] ` <20101126215254.GJ2767@thunk.org>
[not found] ` <20101127075831.GC24433@burratino>
[not found] ` <20101127085346.GD14011@rivendell.home.ouaza.com>
[not found] ` <20101129041152.GQ2767@thunk.org>
2010-11-29 7:29 ` Bug#605009: serious performance regression with ext4 Jonathan Nieder
2010-11-29 14:44 ` Ted Ts'o
2010-11-29 15:18 ` Bernd Schubert
2010-11-29 15:37 ` Ted Ts'o [this message]
2010-11-29 15:54 ` Eric Sandeen
2010-11-29 16:20 ` Bernd Schubert
2010-11-29 16:27 ` Florian Weimer
2010-11-29 20:50 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129153702.GB7994@thunk.org \
--to=tytso@mit.edu \
--cc=bernd.schubert@fastmail.fm \
--cc=jrnieder@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).