From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Set barrier=0 when block device does not advertise flush support
Date: Fri, 3 Dec 2010 02:09:50 -0500 [thread overview]
Message-ID: <20101203070950.GA19071@infradead.org> (raw)
In-Reply-To: <20101203001659.GI18195@tux1.beaverton.ibm.com>
On Thu, Dec 02, 2010 at 04:16:59PM -0800, Darrick J. Wong wrote:
> If the user tries to enable write flushes with "barrier=1" and the underlying
> block device does not support flushes, print a message and set barrier=0.
That doesn't make any sense at all with the ne wFLUSH+FUA code, which is
designed to make the cache flushing entirely transparanent. Basically
with the new code the barrier option should become a no-op and always
enabled.
next prev parent reply other threads:[~2010-12-03 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 0:16 [PATCH] ext4: Set barrier=0 when block device does not advertise flush support Darrick J. Wong
2010-12-03 7:09 ` Christoph Hellwig [this message]
2010-12-03 9:14 ` Darrick J. Wong
2010-12-06 13:39 ` Christoph Hellwig
2010-12-06 18:09 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203070950.GA19071@infradead.org \
--to=hch@infradead.org \
--cc=djwong@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).