From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <andreas.dilger@oracle.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fix debugfs output for flex_bg bitmap offsets
Date: Sun, 5 Dec 2010 22:16:58 -0500 [thread overview]
Message-ID: <20101206031658.GH4273@thunk.org> (raw)
In-Reply-To: <B5F6E86E-D94A-4ECC-9B55-FCE9E219DFF1@oracle.com>
On Fri, Nov 26, 2010 at 05:33:27PM -0700, Andreas Dilger wrote:
> On 2010-11-25, at 12:09, Andreas Dilger wrote:
> > ...with patch this time...
>
> Attached is an updated patch that makes the output a bit more
> verbose (to avoid line wraps) and doesn't fail the m_raid_opts test
> (which complains when "(+0)" is printed for each inode table).
Every time you write code of the form:
if (block >= first_block + !!itable && ...)
Gcc kills a kitten. Please, think of the kittens....
I rewrote that code as follows:
if ((block >= first_block) && (block <= last_block)) {
if (itable && block == first_block)
return;
printf(" (+%u)", (unsigned)(block - first_block));
} else if ...
I also changed the output to use "(bg #16 + 4)" since I think it's a
bit easier to understand than "(grp 16+4)".
Otherwise, I've added it to the e2fsprogs maint branch, thanks.
- Ted
prev parent reply other threads:[~2010-12-06 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 9:57 [PATCH] fix debugfs output for flex_bg bitmap offsets Andreas Dilger
2010-11-25 19:09 ` Andreas Dilger
2010-11-27 0:33 ` Andreas Dilger
2010-12-06 3:16 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101206031658.GH4273@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=andreas.dilger@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).