linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Set barrier=0 when block device does not advertise flush support
Date: Mon, 6 Dec 2010 10:09:42 -0800	[thread overview]
Message-ID: <20101206180942.GL18195@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20101206133924.GB9235@infradead.org>

On Mon, Dec 06, 2010 at 08:39:24AM -0500, Christoph Hellwig wrote:
> barrier=0 really means losemydata=1.  The plan I discussed with Jens was
> to allow to disable the flush and fua semantics in the block layer, so
> we'll have one new tunable for that, which is documented to causes these
> issues.  

Oh.  I wasn't aware that anyone was planning to put in a tuning knob for
flush/fua, red warning light or otherwise.  What is the name of the tunable,
and when will it appear?  Or has it already?

> > picks the safe option by default.  However, I'd prefer /proc/mounts not
> > misrepresent the status of flush support, to the best of ext4's knowledge.
> 
> That's bullshit.  The barrier option has traditionally meant that we

Well then, let's remove the barrier= mount flag altogether.  No need for strong
language over a minor issue. :)  When I see some patches I will push this
through my testing setup and report back what data I collect.

--D

> sent barrier requests, and now means thatwe send flush+fua requests.
> There's no reason for a warning and option mislabling just because you
> got the most efficient implementation of it.

      reply	other threads:[~2010-12-06 18:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03  0:16 [PATCH] ext4: Set barrier=0 when block device does not advertise flush support Darrick J. Wong
2010-12-03  7:09 ` Christoph Hellwig
2010-12-03  9:14   ` Darrick J. Wong
2010-12-06 13:39     ` Christoph Hellwig
2010-12-06 18:09       ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101206180942.GL18195@tux1.beaverton.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).