* [PATCH] ext4: Remove redundant unlikely()
@ 2010-12-09 14:40 Tobias Klauser
2010-12-20 2:39 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-12-09 14:40 UTC (permalink / raw)
To: Theodore Ts'o, Andreas Dilger, linux-ext4; +Cc: kernel-janitors
IS_ERR() already implies unlikely(), so it can be omitted here.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
fs/ext4/namei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 92203b8..cec88ce 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1036,7 +1036,7 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, stru
return ERR_PTR(-EIO);
}
inode = ext4_iget(dir->i_sb, ino);
- if (unlikely(IS_ERR(inode))) {
+ if (IS_ERR(inode)) {
if (PTR_ERR(inode) == -ESTALE) {
EXT4_ERROR_INODE(dir,
"deleted inode referenced: %u",
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ext4: Remove redundant unlikely()
2010-12-09 14:40 [PATCH] ext4: Remove redundant unlikely() Tobias Klauser
@ 2010-12-20 2:39 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-12-20 2:39 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Andreas Dilger, linux-ext4, kernel-janitors
On Thu, Dec 09, 2010 at 04:40:38AM -0000, Tobias Klauser wrote:
> IS_ERR() already implies unlikely(), so it can be omitted here.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Thanks, added to ext4 patch queue.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-20 2:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 14:40 [PATCH] ext4: Remove redundant unlikely() Tobias Klauser
2010-12-20 2:39 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).