linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] ext4: testing the wrong variable in ext4_init_pageio()
@ 2010-12-23 19:09 Dan Carpenter
  2010-12-24  9:57 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-12-23 19:09 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, kernel-janitors

This is a copy and paste error.  The intent was to check
"io_page_cachep".  We tested "io_page_cachep" earlier.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index beacce1..857abc6 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -44,7 +44,7 @@ int __init ext4_init_pageio(void)
 	if (io_page_cachep == NULL)
 		return -ENOMEM;
 	io_end_cachep = KMEM_CACHE(ext4_io_end, SLAB_RECLAIM_ACCOUNT);
-	if (io_page_cachep == NULL) {
+	if (io_end_cachep == NULL) {
 		kmem_cache_destroy(io_page_cachep);
 		return -ENOMEM;
 	}

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] ext4: testing the wrong variable in ext4_init_pageio()
  2010-12-23 19:09 [patch] ext4: testing the wrong variable in ext4_init_pageio() Dan Carpenter
@ 2010-12-24  9:57 ` Ted Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-12-24  9:57 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: Andreas Dilger, linux-ext4, kernel-janitors

On Thu, Dec 23, 2010 at 10:09:11PM +0300, Dan Carpenter wrote:
> This is a copy and paste error.  The intent was to check
> "io_page_cachep".  We tested "io_page_cachep" earlier.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Thanks, added to the ext4 patch queue.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-24  9:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-23 19:09 [patch] ext4: testing the wrong variable in ext4_init_pageio() Dan Carpenter
2010-12-24  9:57 ` Ted Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).