* [PATCH] ext4: ext4_ext_migrate should use NULL not 0
@ 2010-12-08 19:16 Eric Paris
2010-12-30 13:07 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Eric Paris @ 2010-12-08 19:16 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, eparis
ext4_ext_migrate() calls ext4_new_inode() and passes 0 instead of a pointer
to a struct qstr. This patch uses NULL, to make it obvious to the caller
that this was a pointer.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
fs/ext4/migrate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/migrate.c b/fs/ext4/migrate.c
index 25f3a97..b0a126f 100644
--- a/fs/ext4/migrate.c
+++ b/fs/ext4/migrate.c
@@ -496,7 +496,7 @@ int ext4_ext_migrate(struct inode *inode)
goal = (((inode->i_ino - 1) / EXT4_INODES_PER_GROUP(inode->i_sb)) *
EXT4_INODES_PER_GROUP(inode->i_sb)) + 1;
tmp_inode = ext4_new_inode(handle, inode->i_sb->s_root->d_inode,
- S_IFREG, 0, goal);
+ S_IFREG, NULL, goal);
if (IS_ERR(tmp_inode)) {
retval = -ENOMEM;
ext4_journal_stop(handle);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: ext4_ext_migrate should use NULL not 0
2010-12-08 19:16 [PATCH] ext4: ext4_ext_migrate should use NULL not 0 Eric Paris
@ 2010-12-30 13:07 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-12-30 13:07 UTC (permalink / raw)
To: Eric Paris; +Cc: linux-ext4
On Wed, Dec 08, 2010 at 02:16:10PM -0500, Eric Paris wrote:
> ext4_ext_migrate() calls ext4_new_inode() and passes 0 instead of a pointer
> to a struct qstr. This patch uses NULL, to make it obvious to the caller
> that this was a pointer.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
Thanks, applied to the ext4 patch tree.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-30 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 19:16 [PATCH] ext4: ext4_ext_migrate should use NULL not 0 Eric Paris
2010-12-30 13:07 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).