From: Dan Carpenter <error27@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: smatch stuff: -next: null dereference in ext4_readdir()
Date: Sat, 1 Jan 2011 16:40:13 +0300 [thread overview]
Message-ID: <20110101134013.GI1886@bicker> (raw)
Hi Ted,
There is a NULL dereference introduced in linux-next "ext4: Use
ext4_error_file() to print the pathname to the corrupted inode"
fs/ext4/dir.c +170 ext4_readdir(59) error: potential null derefence 'bh'.
168 if (!bh) {
169 if (!dir_has_error) {
170 EXT4_ERROR_FILE(filp, bh->b_blocknr,
^^^^^^^^^^^^^
"bh" is null here.
171 "directory contains a "
172 "hole at offset %Lu",
173 (unsigned long long) filp->f_pos);
174 dir_has_error = 1;
regards,
dan carpenter
next reply other threads:[~2011-01-01 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 13:40 Dan Carpenter [this message]
2011-01-02 23:11 ` smatch stuff: -next: null dereference in ext4_readdir() Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110101134013.GI1886@bicker \
--to=error27@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).