* smatch stuff: -next: null dereference in ext4_readdir()
@ 2011-01-01 13:40 Dan Carpenter
2011-01-02 23:11 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-01-01 13:40 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: linux-ext4
Hi Ted,
There is a NULL dereference introduced in linux-next "ext4: Use
ext4_error_file() to print the pathname to the corrupted inode"
fs/ext4/dir.c +170 ext4_readdir(59) error: potential null derefence 'bh'.
168 if (!bh) {
169 if (!dir_has_error) {
170 EXT4_ERROR_FILE(filp, bh->b_blocknr,
^^^^^^^^^^^^^
"bh" is null here.
171 "directory contains a "
172 "hole at offset %Lu",
173 (unsigned long long) filp->f_pos);
174 dir_has_error = 1;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: smatch stuff: -next: null dereference in ext4_readdir()
2011-01-01 13:40 smatch stuff: -next: null dereference in ext4_readdir() Dan Carpenter
@ 2011-01-02 23:11 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-01-02 23:11 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-ext4
On Sat, Jan 01, 2011 at 04:40:13PM +0300, Dan Carpenter wrote:
> Hi Ted,
>
> There is a NULL dereference introduced in linux-next "ext4: Use
> ext4_error_file() to print the pathname to the corrupted inode"
Thanks for catching this! I'll fix up the bad patch in the ext4 patch
tree and regen the tree.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 2:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-01 13:40 smatch stuff: -next: null dereference in ext4_readdir() Dan Carpenter
2011-01-02 23:11 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).