* [PATCH] ext2: Remove redundant unlikely()
@ 2010-12-09 14:39 Tobias Klauser
2011-01-06 15:44 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-12-09 14:39 UTC (permalink / raw)
To: Jan Kara, linux-ext4; +Cc: kernel-janitors
IS_ERR() already implies unlikely(), so it can be omitted here.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
fs/ext2/namei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index f8aecd2..2e1d834 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -67,7 +67,7 @@ static struct dentry *ext2_lookup(struct inode * dir, struct dentry *dentry, str
inode = NULL;
if (ino) {
inode = ext2_iget(dir->i_sb, ino);
- if (unlikely(IS_ERR(inode))) {
+ if (IS_ERR(inode)) {
if (PTR_ERR(inode) == -ESTALE) {
ext2_error(dir->i_sb, __func__,
"deleted inode referenced: %lu",
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ext2: Remove redundant unlikely()
2010-12-09 14:39 [PATCH] ext2: Remove redundant unlikely() Tobias Klauser
@ 2011-01-06 15:44 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2011-01-06 15:44 UTC (permalink / raw)
To: Tobias Klauser; +Cc: Jan Kara, linux-ext4, kernel-janitors
On Thu 09-12-10 15:39:00, Tobias Klauser wrote:
> IS_ERR() already implies unlikely(), so it can be omitted here.
Thanks. Merged.
Honza
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> fs/ext2/namei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
> index f8aecd2..2e1d834 100644
> --- a/fs/ext2/namei.c
> +++ b/fs/ext2/namei.c
> @@ -67,7 +67,7 @@ static struct dentry *ext2_lookup(struct inode * dir, struct dentry *dentry, str
> inode = NULL;
> if (ino) {
> inode = ext2_iget(dir->i_sb, ino);
> - if (unlikely(IS_ERR(inode))) {
> + if (IS_ERR(inode)) {
> if (PTR_ERR(inode) == -ESTALE) {
> ext2_error(dir->i_sb, __func__,
> "deleted inode referenced: %lu",
> --
> 1.7.0.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-06 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-09 14:39 [PATCH] ext2: Remove redundant unlikely() Tobias Klauser
2011-01-06 15:44 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).