From: Ted Ts'o <tytso@mit.edu>
To: Hugh Dickins <hughd@google.com>
Cc: Amir Goldstein <amir73il@users.sf.net>,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: ext4: ext23 support leaks buffer pages
Date: Mon, 10 Jan 2011 12:52:34 -0500 [thread overview]
Message-ID: <20110110175234.GD3128@thunk.org> (raw)
In-Reply-To: <alpine.LSU.2.00.1101100242530.2000@sister.anvils>
On Mon, Jan 10, 2011 at 02:54:26AM -0800, Hugh Dickins wrote:
> I switched to CONFIG_EXT4_USE_FOR_EXT23=y with 2.6.37, but was
> then surprised by OOM kills: 2.6.36 and current are also bad.
Oops. Yeah, the problem was when ext4_forget() was moved out of
ext4_free_branches, we needed to replace it with a call to brelse().
Thanks for pointing this out.
Patch follows...
- Ted
next prev parent reply other threads:[~2011-01-10 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 10:54 ext4: ext23 support leaks buffer pages Hugh Dickins
2011-01-10 17:52 ` Ted Ts'o [this message]
2011-01-10 17:56 ` [PATCH] ext4: fix memory leak in ext4_free_branches Theodore Ts'o
2011-01-11 0:02 ` Hugh Dickins
2011-01-11 10:16 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110175234.GD3128@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@users.sf.net \
--cc=hughd@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).