From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: don't pass entire map to check_eofblocks_fl
Date: Mon, 10 Jan 2011 13:13:02 -0500 [thread overview]
Message-ID: <20110110181302.GE3128@thunk.org> (raw)
In-Reply-To: <4D2B47FB.1040909@redhat.com>
On Mon, Jan 10, 2011 at 11:55:07AM -0600, Eric Sandeen wrote:
>
> Since check_eofblocks_fl() only uses the m_lblk portion of
> the map structure, we may as well pass that directly, rather
> than passing the entire map, which IMHO obfuscates what
> parameters check_eofblocks_fl() cares about. Not a big
> deal, but seems tidier and less confusing, to me.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Thanks, added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2011-01-10 18:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 17:55 [PATCH] ext4: don't pass entire map to check_eofblocks_fl Eric Sandeen
2011-01-10 18:13 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110181302.GE3128@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).