From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@kernel.dk>,
"Theodore Ts'o" <tytso@mit.edu>, Neil Brown <neilb@suse.de>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>, Mike Snitzer <snitzer@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Keith Mannthey <kmannth@us.ibm.com>,
Mingming Cao <cmm@us.ibm.com>,
linux-ext4@vger.kernel.org, Ric Wheeler <rwheeler@redhat.com>,
Christoph Hellwig <hch@lst.de>, Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH v7.1] block: Coordinate flush requests
Date: Thu, 20 Jan 2011 22:41:49 -0800 [thread overview]
Message-ID: <20110121064149.GH27381@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20110120191341.GB4701@htj.dyndns.org>
On Thu, Jan 20, 2011 at 08:13:41PM +0100, Tejun Heo wrote:
> On Thu, Jan 20, 2011 at 07:50:57PM +0100, Tejun Heo wrote:
> > Hello,
> >
> > On Tue, Jan 18, 2011 at 09:12:55AM +0800, Shaohua Li wrote:
> > > This makes sense. would it possible N flush data payloads delay the
> > > first request?
> >
> > I ended up with a different design. Still buggy. It triggers a weird
> > oops under stress test but other than that things generally seem to
> > work as expected. Please read the comment at the top of blk-flush.c
> > for more info. I'll post properly after more testing and debugging.
>
> The oops was caused by debugging code I put in (not posted together).
> It runs fine without it, so if you have some time, please give it a
> spin.
Seems to run without incident on my storage test arrays. The fsync-happy
performance numbers are comparable to previous iterations of flush patches.
Looks good, thank you!
--D
next prev parent reply other threads:[~2011-01-21 6:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 2:56 [PATCH v7.1] block: Coordinate flush requests Darrick J. Wong
2011-01-13 5:38 ` Shaohua Li
2011-01-13 7:46 ` Darrick J. Wong
2011-01-14 1:00 ` Shaohua Li
2011-01-14 21:00 ` Darrick J. Wong
2011-01-15 17:32 ` Tejun Heo
2011-01-18 1:12 ` Shaohua Li
2011-01-20 18:50 ` Tejun Heo
2011-01-20 19:13 ` Tejun Heo
2011-01-21 6:41 ` Darrick J. Wong [this message]
2011-01-13 10:42 ` Tejun Heo
2011-01-13 18:59 ` Darrick J. Wong
2011-01-15 13:33 ` Tejun Heo
2011-01-19 8:58 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121064149.GH27381@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=cmm@us.ibm.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=josef@redhat.com \
--cc=kmannth@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).