From: Joel Becker <jlbec@evilplan.org>
To: Jan Kara <jack@suse.cz>
Cc: Ted Ts'o <tytso@mit.edu>, Manish Katiyar <mkatiyar@gmail.com>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.
Date: Mon, 24 Jan 2011 09:20:23 -0800 [thread overview]
Message-ID: <20110124172020.GB22970@noexit> (raw)
In-Reply-To: <20110124133143.GA5058@quack.suse.cz>
On Mon, Jan 24, 2011 at 02:31:43PM +0100, Jan Kara wrote:
> On Sat 22-01-11 22:29:01, Joel Becker wrote:
> > This API is markedly better to read. Btw, does _nofail() mean no
> > possible failures, or just no memory errors? If it is no failures, I'd
> > love to see the function become void.
> jbd2_journal_start can always fail e.g. because the journal is aborted.
> So it really just means no memory failures...
Then _nofail() is a terrible name, because it can still fail.
Let's call it jbd2_journal_start_nofs(); that's what it is.
Joel
--
"Under capitalism, man exploits man. Under Communism, it's just
the opposite."
- John Kenneth Galbraith
http://www.jlbec.org/
jlbec@evilplan.org
next prev parent reply other threads:[~2011-01-24 17:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 3:32 [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully Manish Katiyar
2011-01-23 5:40 ` Ted Ts'o
2011-01-23 5:53 ` Manish Katiyar
2011-01-23 6:29 ` Joel Becker
2011-01-24 13:31 ` Jan Kara
2011-01-24 17:20 ` Joel Becker [this message]
2011-01-25 11:40 ` Jan Kara
2011-01-25 0:06 ` Andreas Dilger
2011-01-25 11:46 ` Jan Kara
2011-01-30 5:40 ` Manish Katiyar
2011-02-04 15:53 ` Jan Kara
2011-02-04 22:44 ` Manish Katiyar
2011-04-25 0:06 ` Manish Katiyar
2011-01-25 6:47 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124172020.GB22970@noexit \
--to=jlbec@evilplan.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).