From: Jan Kara <jack@suse.cz>
To: Joel Becker <jlbec@evilplan.org>
Cc: Jan Kara <jack@suse.cz>, Ted Ts'o <tytso@mit.edu>,
Manish Katiyar <mkatiyar@gmail.com>,
ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully.
Date: Tue, 25 Jan 2011 12:40:20 +0100 [thread overview]
Message-ID: <20110125114020.GA4088@quack.suse.cz> (raw)
In-Reply-To: <20110124172020.GB22970@noexit>
On Mon 24-01-11 09:20:23, Joel Becker wrote:
> On Mon, Jan 24, 2011 at 02:31:43PM +0100, Jan Kara wrote:
> > On Sat 22-01-11 22:29:01, Joel Becker wrote:
> > > This API is markedly better to read. Btw, does _nofail() mean no
> > > possible failures, or just no memory errors? If it is no failures, I'd
> > > love to see the function become void.
> > jbd2_journal_start can always fail e.g. because the journal is aborted.
> > So it really just means no memory failures...
>
> Then _nofail() is a terrible name, because it can still fail.
> Let's call it jbd2_journal_start_nofs(); that's what it is.
Good point. But it's not even NO_FS - that's just an internal thing how
JBD2 abuses gfp flags to communicate it's wish. It should really be "do not
fail if there is still hope because user will silently loose data if you
do". But that's obviously too long for a function name suffix ;). I'm
looking for a better name... Andreas' _retry does not well describe what's
the desired effect either.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-01-25 11:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-23 3:32 [PATCH 1/3] jbd2 : Make jbd2 transaction handle allocation to return errors and handle them gracefully Manish Katiyar
2011-01-23 5:40 ` Ted Ts'o
2011-01-23 5:53 ` Manish Katiyar
2011-01-23 6:29 ` Joel Becker
2011-01-24 13:31 ` Jan Kara
2011-01-24 17:20 ` Joel Becker
2011-01-25 11:40 ` Jan Kara [this message]
2011-01-25 0:06 ` Andreas Dilger
2011-01-25 11:46 ` Jan Kara
2011-01-30 5:40 ` Manish Katiyar
2011-02-04 15:53 ` Jan Kara
2011-02-04 22:44 ` Manish Katiyar
2011-04-25 0:06 ` Manish Katiyar
2011-01-25 6:47 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125114020.GA4088@quack.suse.cz \
--to=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=mkatiyar@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).