From: Tejun Heo <tj@kernel.org>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
axboe@kernel.dk, tytso@mit.edu, shli@kernel.org, neilb@suse.de,
adilger.kernel@dilger.ca, jack@suse.cz, snitzer@redhat.com,
linux-kernel@vger.kernel.org, kmannth@us.ibm.com, cmm@us.ibm.com,
linux-ext4@vger.kernel.org, rwheeler@redhat.com, hch@lst.de,
josef@redhat.com
Subject: Re: [PATCH 1/3] block: Create sysfs knobs to override FLUSH/FUA support flags
Date: Wed, 26 Jan 2011 10:30:51 +0100 [thread overview]
Message-ID: <20110126093051.GA12520@htj.dyndns.org> (raw)
In-Reply-To: <20110126071626.GI27190@tux1.beaverton.ibm.com>
On Tue, Jan 25, 2011 at 11:16:26PM -0800, Darrick J. Wong wrote:
> This patch is the first in a series to refactor the barrier= mount options out
> of the filesystem code. This patch adds sysfs knobs to disable flush and FUA;
> of course, the automatic default is the safe choice, i.e. to leave them
> enabled. Obviously, only a seasoned administrator should ever be overriding
> the defaults.
Hmmm... wouldn't it be better to just export flush and fua instead of
ignore_*? So that the admin can turn things on and off as [s]he seems
fit? Also, it might be better to export them in a single attribute,
say cache_control or something. Only subset of the combinations make
sense anyway - none, flush, flush_fua.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-01-26 9:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110126071200.GE32261@tux1.beaverton.ibm.com>
[not found] ` <20110126072329.GK27190@tux1.beaverton.ibm.com>
2011-01-26 9:36 ` [PATCH 3/3] ext4: Deprecate barrier= and nobarrier mount options Tejun Heo
2011-01-26 10:47 ` Jan Kara
2011-01-26 10:51 ` Tejun Heo
2011-01-26 12:16 ` Ric Wheeler
2011-01-26 12:21 ` Tejun Heo
2011-01-26 13:29 ` torn5
2011-01-26 11:47 ` [PATCHSET] Refactor barrier=/nobarrier flags from fs to block layer Ric Wheeler
2011-01-26 11:49 ` Ric Wheeler
2011-01-26 16:41 ` Eric Sandeen
2011-01-26 17:24 ` Darrick J. Wong
2011-01-28 11:16 ` Dave Chinner
[not found] ` <20110126071626.GI27190@tux1.beaverton.ibm.com>
2011-01-26 9:30 ` Tejun Heo [this message]
2011-01-26 17:00 ` [PATCH 1/3] block: Create sysfs knobs to override FLUSH/FUA support flags Darrick J. Wong
2011-02-05 16:20 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126093051.GA12520@htj.dyndns.org \
--to=tj@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=cmm@us.ibm.com \
--cc=djwong@us.ibm.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=josef@redhat.com \
--cc=kmannth@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rwheeler@redhat.com \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).