linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Jan Kara <jack@suse.cz>, ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/3] ext4 : Pass GFP_KERNEL for transaction allocation if caller can handler failures
Date: Sun, 30 Jan 2011 15:07:12 -0500	[thread overview]
Message-ID: <20110130200712.GF4258@thunk.org> (raw)
In-Reply-To: <AANLkTik8_iO=LF=HqmZyNGC=t5TVqEHzb=G78M-NWMHR@mail.gmail.com>

On Sun, Jan 30, 2011 at 11:44:25AM -0800, Manish Katiyar wrote:
> 
> Do you mean separate patch for each of the changed functions ?

Unless the cleanups for a set of functions are all the same issue,
yes.  The idea is that commit description should apply to all of the
patch hunks in the commit.

That way if there is a problem, it becomes easier to bisect and then
determine what's going on by reading the commit description.  It also
becomes easier to review the changes, as well.

Does that make sense?

Thanks,

					- Ted

  reply	other threads:[~2011-01-30 20:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-23  3:34 [PATCH 2/3] ext4 : Pass GFP_KERNEL for transaction allocation if caller can handler failures Manish Katiyar
2011-01-25 16:17 ` Jan Kara
2011-01-25 20:05   ` Manish Katiyar
2011-01-26  7:55     ` Lukas Czerner
2011-01-26  7:58       ` Manish Katiyar
2011-01-30 19:42     ` Ted Ts'o
2011-01-30 19:44       ` Manish Katiyar
2011-01-30 20:07         ` Ted Ts'o [this message]
2011-01-31  1:04           ` Manish Katiyar
2011-01-30  5:29   ` Manish Katiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110130200712.GF4258@thunk.org \
    --to=tytso@mit.edu \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).