Re: [LSF/MM TOPIC] Drop ext2/ext3 codebase? When?

[Jan Kara <jack@suse.cz>]

On Thu 03-02-11 23:57:25, Amir Goldstein wrote:
> On Thu, Feb 3, 2011 at 9:49 PM, Eric Sandeen <sandeen@redhat.com> wrote:
> Can you give a rough estimate of how those commits diverge between
> bugfixes, kernel API changes, code cleanups?
> 
> Next3 has been following ext3 since 2.6.31 and I remember changes of
> the 2 latter, but not many major bugfixes.
  So I took the work and went through the commit log of ext3 since 2.6.19
(when ext4 was merged). We have
305 commits in total, from those are:
62 cleanups
113 bugfixes
105 changes because of API changing or other kernel-wide efforts
25 features, speedups, and similar

The cathegorization of commits is somewhat arbitrary in some cases but I
think the numbers should be roughly fair...

> I hardly think we can get away with throwing out ext3 code base, but
> maybe it can go into bugfixes-only mode? that is unless Jan likes to
> apply cleanups ;-)
  As you can see, it pretty much is. 25 feature commits in 5 years (and
those features are often like - report mount options in /proc/mounts,
unify error messages, avoid loading bitmap when block group is full, etc.)
is IMHO bugfixes-only mode if you don't want the filesystem to start
bitrotting. I've merged one bigger feature in last year and that was FITRIM
support on the grounds that it did not touch any code outside of FITRIM ioctl
handling itself. So when Lukas wanted to do the work with implementing it,
I was OK with it.

Sure I could be harder on people pushing cleanups on me but I don't want to
scare newbies away so I try to be nice and if the result actually is
better, I take it.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR