From: Ted Ts'o <tytso@mit.edu>
To: Milan Broz <mbroz@redhat.com>
Cc: Matt <jackdachef@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: ext4: Fix data corruption with multi-block writepages support
Date: Mon, 7 Feb 2011 15:44:19 -0500 [thread overview]
Message-ID: <20110207204419.GE3457@thunk.org> (raw)
In-Reply-To: <4D503A06.3010403@redhat.com>
On Mon, Feb 07, 2011 at 07:29:26PM +0100, Milan Broz wrote:
>
> So it was ext4 only bug in ext4_end_bio(),
> dm-crypt per-cpu code was just trigger here, right?
There appeared to be two bugs that people were discussing on that
particular dm_crypt mail thread. Some people were complaining about
issues with dm_crypt even when ext4 was not involved.
So I think it's fair to say that there was definitely _a_ ext4 bug
which was most easily seen when dm_crypt was in play, but which was
definitely not dm_crypt specific (it was possible to see it on an
hdd-only system, but the workload was much more severe). In any case,
as soon as the problem was found, we disabled the ext4 optimization
in 2.6.37-rc5.
So the fact that we found and fixed an ext4 bug that was triggered by
dm_crypt should not be taken as a statement (one way or the other)
that dm_crypt is Bug-Free(tm). :-)
- Ted
next prev parent reply other threads:[~2011-02-07 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 22:40 ext4: Fix data corruption with multi-block writepages support Matt
2011-02-07 17:45 ` Ted Ts'o
2011-02-07 18:29 ` Milan Broz
2011-02-07 18:44 ` Matt
2011-02-07 20:44 ` Ted Ts'o [this message]
2011-02-07 20:51 ` Milan Broz
2011-02-07 18:56 ` Matt
-- strict thread matches above, loose matches on Subject: below --
2011-02-01 17:51 Curt Wohlgemuth
2011-02-03 18:38 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207204419.GE3457@thunk.org \
--to=tytso@mit.edu \
--cc=jackdachef@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).