From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: i@coly.li, Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 0/5] mballoc: trivial code cleanup
Date: Mon, 7 Feb 2011 17:24:50 -0500 [thread overview]
Message-ID: <20110207222450.GF3457@thunk.org> (raw)
In-Reply-To: <AANLkTimOaQSdJa9aXEs_UM0pAO92S0_zGT5w7kU33etk@mail.gmail.com>
On Mon, Feb 07, 2011 at 10:59:54PM +0200, Amir Goldstein wrote:
> it says alloc_sem protects against lazy init of adjacent groups
> and says nothing about protecting block group specific data structures...
>
> what am I missing???
You're missing ext4_mb_load_buddy(), which takes grp->alloc_sem, and
which is released by ext4_mb_unload_buddy(). No, it's not the most
obvious code in the world...
- Ted
next prev parent reply other threads:[~2011-02-07 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 4:53 [PATCH 0/5] mballoc: trivial code cleanup Coly Li
2011-02-06 8:43 ` Amir Goldstein
2011-02-07 17:41 ` Ted Ts'o
2011-02-07 20:59 ` Amir Goldstein
2011-02-07 22:24 ` Ted Ts'o [this message]
2011-02-08 8:54 ` Amir Goldstein
2011-02-09 9:09 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207222450.GF3457@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=i@coly.li \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).