linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: Andreas Dilger <adilger@dilger.ca>, ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths.
Date: Mon, 7 Feb 2011 18:23:43 -0500	[thread overview]
Message-ID: <20110207232343.GA26289@thunk.org> (raw)
In-Reply-To: <AANLkTim0XZe2=3AWw4Ydb8F7BQGCf+=FyjKoyadc+3yw@mail.gmail.com>

On Sat, Jan 29, 2011 at 09:40:34PM -0800, Manish Katiyar wrote:
> 
> Any feedback on this ?

The patch looks good, but it doesn't fix bug #26752.

The root cause of that bug is the fact that ext4_sync_fs() and
ext4_put_super() assumes that sbi has been initialized.

		 	      	      - Ted

  reply	other threads:[~2011-02-07 23:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-16  7:30 [PATCH] ext4: Fix missing iput for root inode in case of all failed mount paths Manish Katiyar
2011-01-16 16:20 ` Andreas Dilger
2011-01-16 18:05   ` Manish Katiyar
2011-01-30  5:40     ` Manish Katiyar
2011-02-07 23:23       ` Ted Ts'o [this message]
2011-02-07 23:31         ` Manish Katiyar
2011-02-26 21:35           ` Manish Katiyar
2011-02-28  1:45             ` Ted Ts'o
2011-02-28  4:19               ` Manish Katiyar
2011-07-06 22:54     ` Andreas Dilger
2011-07-10 19:11       ` Manish Katiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110207232343.GA26289@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).