From: Ted Ts'o <tytso@mit.edu>
To: Mark Lord <kernel@teksavvy.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ext4@vger.kernel.org
Subject: Re: ext4 crash on 2.6.37: NULL ptr in ext4_discard_preallocations
Date: Sun, 20 Feb 2011 01:15:52 -0500 [thread overview]
Message-ID: <20110220061552.GB8765@thunk.org> (raw)
In-Reply-To: <4D60A117.8090604@teksavvy.com>
On Sun, Feb 20, 2011 at 12:05:27AM -0500, Mark Lord wrote:
> I suppose it must be, as there's no other 0x3c offset in that function.
> Which means it's probably this line that's crashing:
>
> BUG_ON(pa->pa_obj_lock != &ei->i_prealloc_lock);
>
> ...which could only happen if "pa" was NULL there.
> I wonder how that happened ?
Which could only happen if ei->i_prealloc_list were not properly
initialized (i..e, it was still NULL). Which shouldn't ever
happen...., since all ext4_inodes are initialized in
ext4_alloc_inode().
Hmm, can you replicate the crash?
- Ted
next prev parent reply other threads:[~2011-02-20 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 22:37 ext4 crash on 2.6.37: NULL ptr in ext4_discard_preallocations Mark Lord
2011-02-20 0:05 ` Ted Ts'o
2011-02-20 4:54 ` Mark Lord
2011-02-20 5:05 ` Mark Lord
2011-02-20 6:15 ` Ted Ts'o [this message]
2011-02-20 13:55 ` Mark Lord
2011-02-20 14:39 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220061552.GB8765@thunk.org \
--to=tytso@mit.edu \
--cc=kernel@teksavvy.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).