From: Ted Ts'o <tytso@mit.edu>
To: Curt Wohlgemuth <curtw@google.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: mark multi-page IO complete on mapping failure
Date: Sat, 26 Feb 2011 13:54:05 -0500 [thread overview]
Message-ID: <20110226185405.GE2924@thunk.org> (raw)
In-Reply-To: <1298064699-17987-1-git-send-email-curtw@google.com>
On Fri, Feb 18, 2011 at 01:31:38PM -0800, Curt Wohlgemuth wrote:
> In mpage_da_map_and_submit(), if we have a delayed block
> allocation failure from ext4_map_blocks(), we need to mark
> the IO as complete, by setting
>
> mpd->io_done = 1;
>
> Otherwise, we could end up submitting the pages in an outer
> loop; since they are unlocked on mapping failure in
> ext4_da_block_invalidatepages(), this will cause a bug check
> in mpage_da_submit_io().
>
> I tested this by injected failures into ext4_map_blocks().
> Without this patch, a simple fsstress run will bug check;
> with the patch, it works fine.
>
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Thanks, added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2011-02-26 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 21:31 [PATCH 1/2] ext4: mark multi-page IO complete on mapping failure Curt Wohlgemuth
2011-02-18 21:31 ` [PATCH 2/2] ext4: fix ext4_da_block_invalidatepages() to handle page range properly Curt Wohlgemuth
2011-02-26 18:54 ` Ted Ts'o
2011-02-26 18:54 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110226185405.GE2924@thunk.org \
--to=tytso@mit.edu \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).