From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Andreas Dilger <adilger@dilger.ca>,
Eric Sandeen <sandeen@redhat.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: orphan cleanup on readonly fs will corrupt future fs!
Date: Mon, 28 Feb 2011 00:48:41 -0500 [thread overview]
Message-ID: <20110228054841.GR2924@thunk.org> (raw)
In-Reply-To: <AANLkTi=_QBgDutcb7h2XHpjHR6k-4Rj-r6zryMXaNn6e@mail.gmail.com>
On Sat, Feb 26, 2011 at 08:21:47PM +0200, Amir Goldstein wrote:
> Hi guys,
>
> I have just realized something very disturbing -
> that orphan cleanup is not being skipped on readonly mount of ext4/ext3.
>
> I know that journal recovery is done on readonly mount
> and there is problem with that, since nothing happens
> in the fs level.
>
> But orphan cleanup deletes inodes and frees blocks and that
> could be very bad for some RO_COMPAT features, SNAPSHOT
> and BIGALLOC to name two.
Yes, good point. Fortunately it won't be a problem for the BIGALLOC
feature, since other changes in the superblock will cause the kernel's
sanity checks to refuse to mount it until we teach future kernels how
not to freak out when s_blocks_per_group > blocksize * 8, for example.
But yes, this is something we should fix.
- Ted
next prev parent reply other threads:[~2011-02-28 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 18:21 orphan cleanup on readonly fs will corrupt future fs! Amir Goldstein
2011-02-28 5:48 ` Ted Ts'o [this message]
2011-02-28 15:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228054841.GR2924@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).