From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Theodore Tso <tytso@mit.edu>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext3: skip orphan cleanup on rocompat fs
Date: Mon, 28 Feb 2011 19:09:50 +0100 [thread overview]
Message-ID: <20110228180950.GD20805@quack.suse.cz> (raw)
In-Reply-To: <AANLkTimLAL7hPL+Yb392hyVAWEfHtObv7WwjzKt2awur@mail.gmail.com>
On Sat 26-02-11 22:40:19, Amir Goldstein wrote:
> Orphan cleanup is currently executed even on readonly mount.
> It deletes inodes and frees blocks, which could be very bad for some
> RO_COMPAT features, HAS_SNAPSHOT to name one.
>
> Now the damage is done, because current stock kernels may
> corrupt future fs with readonly compatible features,
> when doing orphan cleanup.
>
> This patch skips the orphan cleanup if readonly compatible features
> would prevent the fs from being mounted (or remounted) readwrite.
Thanks Amir. I actually took the version Ted committed to ext4 and ported
it for ext3. Anyway, the patch is in my tree.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-02-28 18:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 20:40 [PATCH] ext3: skip orphan cleanup on rocompat fs Amir Goldstein
2011-02-28 10:14 ` Rogier Wolff
2011-02-28 13:10 ` Amir Goldstein
2011-02-28 18:22 ` Jan Kara
2011-02-28 18:49 ` Ted Ts'o
2011-02-28 19:32 ` Jan Kara
2011-02-28 19:05 ` Eric Sandeen
2011-02-28 18:22 ` Ted Ts'o
2011-02-28 18:09 ` Jan Kara [this message]
2011-03-24 10:34 ` Amir Goldstein
2011-03-24 16:07 ` [stable] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228180950.GD20805@quack.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).