From: Jan Kara <jack@suse.cz>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>,
Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext3: Fix an overflow in ext3_trim_fs.
Date: Fri, 4 Mar 2011 00:40:47 +0100 [thread overview]
Message-ID: <20110303234047.GA22494@quack.suse.cz> (raw)
In-Reply-To: <1299164317-6400-1-git-send-email-tm@tao.ma>
On Thu 03-03-11 22:58:37, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> In a bs=4096 volume, if we call FITRIM with the following parameter as
> fstrim_range(start = 102400, len = 134144000, minlen = 10240), with the
> following code:
> if (len >= EXT3_BLOCKS_PER_GROUP(sb))
> len -= (EXT3_BLOCKS_PER_GROUP(sb) - first_block);
> else
> last_block = first_block + len;
>
> So if len < EXT3_BLOCKS_PER_GROUP while first_block + len >
> EXT3_BLOCKS_PER_GROUP, last_block will be set to an overflow value
> which exceeds EXT3_BLOCKS_PER_GROUP.
>
> This patch fixes it and adjusts len and last_block accordingly.
Thanks. Merged.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2011-03-03 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 14:58 [PATCH] ext3: Fix an overflow in ext3_trim_fs Tao Ma
2011-03-03 23:40 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303234047.GA22494@quack.suse.cz \
--to=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).