* [PATCH] ext4: critical info format fix in __ext4_grp_locked_error
@ 2011-03-17 1:56 Robin Dong
2011-03-17 2:08 ` [stable] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Robin Dong @ 2011-03-17 1:56 UTC (permalink / raw)
To: linux-ext4; +Cc: Robin Dong, stable
From: Robin Dong <sanbai@taobao.com>
When we do performence-testing on ext4 filesystem, we observe a warning like this:
"[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"
indeed, it should be
"group 2598, 25901 blocks in bitmap, 26057 in gd"
Reviewed-by: Coly Li <bosong.ly@taobao.com>
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index f6a318f..bb38475 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -594,7 +594,7 @@ __acquires(bitlock)
vaf.fmt = fmt;
vaf.va = &args;
- printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u",
+ printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ",
sb->s_id, function, line, grp);
if (ino)
printk(KERN_CONT "inode %lu: ", ino);
--
1.7.3.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [stable] [PATCH] ext4: critical info format fix in __ext4_grp_locked_error
2011-03-17 1:56 [PATCH] ext4: critical info format fix in __ext4_grp_locked_error Robin Dong
@ 2011-03-17 2:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-03-17 2:08 UTC (permalink / raw)
To: Robin Dong; +Cc: linux-ext4, Robin Dong, stable
On Thu, Mar 17, 2011 at 09:56:31AM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
>
> When we do performence-testing on ext4 filesystem, we observe a warning like this:
>
> "[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"
>
> indeed, it should be
>
> "group 2598, 25901 blocks in bitmap, 26057 in gd"
>
> Reviewed-by: Coly Li <bosong.ly@taobao.com>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> ---
<formletter>
This is not how you get a patch applied to the stable tree. Please read
Documentation/stable_kernel_rules.txt for how to properly do this.
thanks,
greg k-h
</formletter>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-17 2:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 1:56 [PATCH] ext4: critical info format fix in __ext4_grp_locked_error Robin Dong
2011-03-17 2:08 ` [stable] " Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).