Re: [PATCH] ext4: critical info format fix in __ext4_grp_locked_error

[Ted Ts'o <tytso@mit.edu>]

Applied to the ext4 patch queue.

On Fri, Mar 18, 2011 at 05:58:03PM +0800, Robin Dong wrote:
> From: Robin Dong <sanbai@taobao.com>
> 
> When we do performence-testing on ext4 filesystem, we observe a warning like this:
> 
> "[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"
> 
> indeed, it should be
> 
> "group 2598, 25901 blocks in bitmap, 26057 in gd"

Note that the next two paragraphs don't really belong in a commit
description.  It's best if you put this kind of stuff after the
signed-off-by lines, with a "---" separating the commit description, like this:

Signed off by: Ty Coon <tycoon@gmail.com>
---
Stuff that explains the context of the patch

diff --git ....

> This bug is found on upstream 2.6.36 kernel. We ran a 2.6.36 kernel
> on the online system with 8 Ext4 file systems. 2 of them are mounted
> with delayed allocation feature. This warning is only observed on
> delayed allocation enabled Ext4 file systems.
> 
> This issue is not easy to reproduce, on two servers with 2.6.36
> kenrel + ext4, after running 110+ days, the error starts to appear
> on kernel log. When check the error log, we found the info format
> should be fixed, that's how this patch comes.

Can you send more information about what sort of workloads your
servers are under, and any other information about how to reproduce
it?

						- Ted