From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC 01/12] ext4: read-only support for bigalloc file systems
Date: Tue, 22 Mar 2011 13:02:20 -0400 [thread overview]
Message-ID: <20110322170220.GC3907@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1103212024460.3724@dhcp-27-109.brq.redhat.com>
On Mon, Mar 21, 2011 at 08:35:20PM +0100, Lukas Czerner wrote:
>
> Maybe this is a bit nitpicky, but should not this be rather done in
> separate commit as it has nothing to do with bigalloc ?
Perhaps. The reason why I had it was because I wanted to see the
blocks per group information when I was testing a read-only bigalloc
mount. I'll grant this is tenuous; I suppose I could separate out
these two patch hunks into a separate patch, but I didn't think it was
really worth it.
>
> I wonder if we should continue at this point, because something
> definitely went wrong as it has not biballoc feature but yet
> s_log_cluster_size does not match s_log_block_size which means
> definitely corruption or an error somewhere.
I considered this, but I was just paranoid because I didn't want to
change anything in the !bigalloc case. There was one or two users who
reported that somehow the second 512 byte sector was containing
garbage, and nothing had cared in the past, but when we first broke
into the second 512 bytes of the superblock we did have some
complaints, so that's why I decided to err on the side of
conservatism.
- Ted
next prev parent reply other threads:[~2011-03-22 17:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 21:28 [PATCH, RFC 00/12] bigalloc patchset Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 01/12] ext4: read-only support for bigalloc file systems Theodore Ts'o
2011-03-21 19:35 ` Lukas Czerner
2011-03-22 17:02 ` Ted Ts'o [this message]
2011-03-23 10:28 ` Lukas Czerner
2011-03-19 21:28 ` [PATCH, RFC 02/12] ext4: enforce bigalloc restrictions (e.g., no online resizing, etc.) Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 03/12] ext4: Convert instances of EXT4_BLOCKS_PER_GROUP to EXT4_CLUSTERS_PER_GROUP Theodore Ts'o
2011-03-20 10:26 ` Amir Goldstein
2011-03-21 13:12 ` Ted Ts'o
2011-03-19 21:28 ` [PATCH, RFC 04/12] ext4: Remove block bitmap initialization in ext4_new_inode() Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 05/12] ext4: factor out block group accounting into functions Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 06/12] ext4: split out ext4_free_blocks_after_init() Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 07/12] ext4: bigalloc changes to block bitmap initialization functions Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 08/12] ext4: Convert block group-relative offsets to use clusters Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 09/12] ext4: teach ext4_ext_map_blocks() about the bigalloc feature Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 10/12] ext4: teach ext4_statfs() to deal with clusters if bigalloc is enabled Theodore Ts'o
2011-03-21 20:17 ` Lukas Czerner
2011-03-22 22:09 ` Ted Ts'o
2011-03-19 21:28 ` [PATCH, RFC 11/12] ext4: tune mballoc's default group prealloc size for bigalloc file systems Theodore Ts'o
2011-03-19 21:28 ` [PATCH, RFC 12/12] ext4: enable mounting bigalloc as read/write Theodore Ts'o
2011-03-20 10:33 ` [PATCH, RFC 00/12] bigalloc patchset Amir Goldstein
2011-03-21 8:55 ` Andreas Dilger
2011-03-21 11:31 ` Rogier Wolff
2011-03-21 13:24 ` Ted Ts'o
2011-03-21 23:42 ` Andreas Dilger
2011-04-05 17:23 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322170220.GC3907@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).