From: Ted Ts'o <tytso@mit.edu>
To: Feng Tang <feng.tang@intel.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep()
Date: Wed, 23 Mar 2011 14:05:45 -0400 [thread overview]
Message-ID: <20110323180545.GA27946@thunk.org> (raw)
In-Reply-To: <1298360438-9521-1-git-send-email-feng.tang@intel.com>
Thanks, added to the ext4 patch tree.
- Ted
On Tue, Feb 22, 2011 at 03:40:38PM +0800, Feng Tang wrote:
> The map_bh() called right before it already set the buffer_head to mapped.
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> ---
> fs/ext4/inode.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9f7f9e4..6fe60f5 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2597,7 +2597,6 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
> * for partial write.
> */
> set_buffer_new(bh);
> - set_buffer_mapped(bh);
> }
> return 0;
> }
> --
> 1.7.0.4
>
prev parent reply other threads:[~2011-03-23 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 7:40 [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep() Feng Tang
2011-03-23 18:05 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323180545.GA27946@thunk.org \
--to=tytso@mit.edu \
--cc=feng.tang@intel.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).