linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep()
@ 2011-02-22  7:40 Feng Tang
  2011-03-23 18:05 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Feng Tang @ 2011-02-22  7:40 UTC (permalink / raw)
  To: linux-ext4, tytso; +Cc: Feng Tang

The map_bh() called right before it already set the buffer_head to mapped.

Signed-off-by: Feng Tang <feng.tang@intel.com>
---
 fs/ext4/inode.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 9f7f9e4..6fe60f5 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2597,7 +2597,6 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
 		 * for partial write.
 		 */
 		set_buffer_new(bh);
-		set_buffer_mapped(bh);
 	}
 	return 0;
 }
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep()
  2011-02-22  7:40 [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep() Feng Tang
@ 2011-03-23 18:05 ` Ted Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-03-23 18:05 UTC (permalink / raw)
  To: Feng Tang; +Cc: linux-ext4

Thanks, added to the ext4 patch tree.

						- Ted

On Tue, Feb 22, 2011 at 03:40:38PM +0800, Feng Tang wrote:
> The map_bh() called right before it already set the buffer_head to mapped.
> 
> Signed-off-by: Feng Tang <feng.tang@intel.com>
> ---
>  fs/ext4/inode.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 9f7f9e4..6fe60f5 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2597,7 +2597,6 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
>  		 * for partial write.
>  		 */
>  		set_buffer_new(bh);
> -		set_buffer_mapped(bh);
>  	}
>  	return 0;
>  }
> -- 
> 1.7.0.4
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-23 18:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-22  7:40 [PATCH] ext4: remove the duplicate set_buffer_mapped() for ext4_da_get_block_prep() Feng Tang
2011-03-23 18:05 ` Ted Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).