linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ext4: unused variables cleanup in check_eofblocks_fl and ext4_ext_map_blocks
@ 2011-03-22 11:51 Sergey Senozhatsky
  2011-03-23 18:10 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Sergey Senozhatsky @ 2011-03-22 11:51 UTC (permalink / raw)
  To: Theodore Ts'o; +Cc: Andreas Dilger, linux-ext4, linux-kernel

ext4 extents cleanup:

  . remove unused `*ex' from check_eofblocks_fl
  . remove unused `*eh' from ext4_ext_map_blocks


Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

---

 fs/ext4/extents.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7516fb9..d89a448 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3108,14 +3108,13 @@ static int check_eofblocks_fl(handle_t *handle, struct inode *inode,
 {
 	int i, depth;
 	struct ext4_extent_header *eh;
-	struct ext4_extent *ex, *last_ex;
+	struct ext4_extent *last_ex;
 
 	if (!ext4_test_inode_flag(inode, EXT4_INODE_EOFBLOCKS))
 		return 0;
 
 	depth = ext_depth(inode);
 	eh = path[depth].p_hdr;
-	ex = path[depth].p_ext;
 
 	if (unlikely(!eh->eh_entries)) {
 		EXT4_ERROR_INODE(inode, "eh->eh_entries == 0 and "
@@ -3295,7 +3294,6 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
 			struct ext4_map_blocks *map, int flags)
 {
 	struct ext4_ext_path *path = NULL;
-	struct ext4_extent_header *eh;
 	struct ext4_extent newex, *ex;
 	ext4_fsblk_t newblock;
 	int err = 0, depth, ret;
@@ -3352,7 +3350,6 @@ int ext4_ext_map_blocks(handle_t *handle, struct inode *inode,
 		err = -EIO;
 		goto out2;
 	}
-	eh = path[depth].p_hdr;
 
 	ex = path[depth].p_ext;
 	if (ex) {


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ext4: unused variables cleanup in check_eofblocks_fl and ext4_ext_map_blocks
  2011-03-22 11:51 [PATCH] ext4: unused variables cleanup in check_eofblocks_fl and ext4_ext_map_blocks Sergey Senozhatsky
@ 2011-03-23 18:10 ` Ted Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-03-23 18:10 UTC (permalink / raw)
  To: Sergey Senozhatsky; +Cc: Andreas Dilger, linux-ext4, linux-kernel

On Tue, Mar 22, 2011 at 01:51:26PM +0200, Sergey Senozhatsky wrote:
> ext4 extents cleanup:
> 
>   . remove unused `*ex' from check_eofblocks_fl
>   . remove unused `*eh' from ext4_ext_map_blocks
> 
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Added to the ext4 patch queue, thanks.

				- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-23 18:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-22 11:51 [PATCH] ext4: unused variables cleanup in check_eofblocks_fl and ext4_ext_map_blocks Sergey Senozhatsky
2011-03-23 18:10 ` Ted Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).