From: Ted Ts'o <tytso@mit.edu>
To: Zhu Yanhai <zhu.yanhai@gmail.com>
Cc: linux-ext4@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>, Zhu Yanhai <gaoyang.zyh@taobao.com>
Subject: Re: [PATCH] jbd2: Move bdget out of critical section
Date: Mon, 4 Apr 2011 12:36:34 -0400 [thread overview]
Message-ID: <20110404163634.GD4706@thunk.org> (raw)
In-Reply-To: <1301734876-22207-1-git-send-email-gaoyang.zyh@taobao.com>
On Sat, Apr 02, 2011 at 05:01:16PM +0800, Zhu Yanhai wrote:
> bdget() should not be called when we hold spinlocks since
> it might sleep.
>
> Signed-off-by: Zhu Yanhai <gaoyang.zyh@taobao.com>
I've added the patch to the patch queue. Technically we should never
have a problem, though, since we only use this for the journal inode,
which is not going to be a fresly created inode. So I don't think we
should ever hit the paths that will result in the kernel sleeping.
But I agree it's better to move it out, if for no other reason to make
life easier for static checkers.
- Ted
prev parent reply other threads:[~2011-04-04 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 9:01 [PATCH] jbd2: Move bdget out of critical section Zhu Yanhai
2011-04-03 9:40 ` Jan Kara
2011-04-04 16:36 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404163634.GD4706@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=gaoyang.zyh@taobao.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=zhu.yanhai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).