From: Ted Ts'o <tytso@mit.edu>
To: shaohua.li@intel.com
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
cl@linux.com, tj@kernel.org, eric.dumazet@gmail.com,
linux-ext4@vger.kernel.org
Subject: Re: [patch v2 2/4] percpu_counter: delete dead code
Date: Sun, 17 Apr 2011 20:12:55 -0400 [thread overview]
Message-ID: <20110418001255.GA19243@thunk.org> (raw)
In-Reply-To: <20110413080517.566936500@sli10-conroe.sh.intel.com>
I'll take care of merging this patch via the ext4 tree.
- Ted
On Wed, Apr 13, 2011 at 03:57:17PM +0800, shaohua.li@intel.com wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> ---
> fs/ext4/balloc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> Index: linux/fs/ext4/balloc.c
> ===================================================================
> --- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
> +++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
> @@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
> EXT4_FREEBLOCKS_WATERMARK) {
> free_blocks = percpu_counter_sum_positive(fbc);
> dirty_blocks = percpu_counter_sum_positive(dbc);
> - if (dirty_blocks < 0) {
> - printk(KERN_CRIT "Dirty block accounting "
> - "went wrong %lld\n",
> - (long long)dirty_blocks);
> - }
> }
> /* Check whether we have space after
> * accounting for current dirty blocks & root reserved blocks.
>
>
parent reply other threads:[~2011-04-18 0:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20110413080517.566936500@sli10-conroe.sh.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418001255.GA19243@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).