* [PATCH]ext4: delete dead code
@ 2011-04-14 2:10 Shaohua Li
2011-04-15 4:16 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Shaohua Li @ 2011-04-14 2:10 UTC (permalink / raw)
To: linux-ext4; +Cc: Ted Ts'o, Tejun Heo
percpu_counter_sum_positive never returns negative.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
fs/ext4/balloc.c | 5 -----
1 file changed, 5 deletions(-)
Index: linux/fs/ext4/balloc.c
===================================================================
--- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
+++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
@@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
EXT4_FREEBLOCKS_WATERMARK) {
free_blocks = percpu_counter_sum_positive(fbc);
dirty_blocks = percpu_counter_sum_positive(dbc);
- if (dirty_blocks < 0) {
- printk(KERN_CRIT "Dirty block accounting "
- "went wrong %lld\n",
- (long long)dirty_blocks);
- }
}
/* Check whether we have space after
* accounting for current dirty blocks & root reserved blocks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]ext4: delete dead code
2011-04-14 2:10 [PATCH]ext4: delete dead code Shaohua Li
@ 2011-04-15 4:16 ` Tejun Heo
2011-04-18 0:19 ` Ted Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2011-04-15 4:16 UTC (permalink / raw)
To: Shaohua Li; +Cc: linux-ext4, Ted Ts'o
On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Ted, can you please pick this up?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]ext4: delete dead code
2011-04-15 4:16 ` Tejun Heo
@ 2011-04-18 0:19 ` Ted Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Ted Ts'o @ 2011-04-18 0:19 UTC (permalink / raw)
To: Tejun Heo; +Cc: Shaohua Li, linux-ext4
On Fri, Apr 15, 2011 at 01:16:10PM +0900, Tejun Heo wrote:
> On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote:
> > percpu_counter_sum_positive never returns negative.
> >
> > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>
>
> Ted, can you please pick this up?
Added to the ext4 tree.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-18 0:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-14 2:10 [PATCH]ext4: delete dead code Shaohua Li
2011-04-15 4:16 ` Tejun Heo
2011-04-18 0:19 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).