linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org>
To: Ted Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
Cc: Andreas Dilger <adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>,
	Eric Sandeen <sandeen-+82itfer+wXR7s880joybQ@public.gmane.org>,
	Yongqiang Yang
	<xiaoqiangnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	xfs-oss <xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org>,
	"coreutils-mXXj517/zsQ@public.gmane.org"
	<coreutils-mXXj517/zsQ@public.gmane.org>,
	"linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Markus Trippelsdorf
	<markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org>
Subject: Re: Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?)
Date: Wed, 20 Apr 2011 07:08:25 +1000	[thread overview]
Message-ID: <20110419210825.GJ23985@dastard> (raw)
In-Reply-To: <20110419140909.GD3030-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>

On Tue, Apr 19, 2011 at 10:09:09AM -0400, Ted Ts'o wrote:
> On Tue, Apr 19, 2011 at 05:45:38PM +1000, Dave Chinner wrote:
> > You are *not listening*. There is no #2. FIEMAP returns the extent
> > state _on disk_ at the time of the call.
> 
> Dave, you're being rather strident about your insistence about what
> FIEMAP's semantics are. 

The bit about the page cache state being relevant? That's what I was
refering to here.

> Part of the problem here is that it's *not*
> clear or settled.
> 
> If it really is the state _on_ _disk_, does XFS really have a DELALLOC
> bit _on_ _disk_?

Sigh. No.

This whole thing blew up because of unwritten extent behaviour when
there is dirty page cache covering and unwritten extent. Delalloc
was not the issue - what I said is absolutely true for unwritten
extents.  Somewhere in the middle someone started talking about
delalloc extents and conflating their behaviour with unwritten
extents, but I continued to talk about unwritten extents and
cached pages.

Even so, for delalloc extents the dirty page state in the page cache
is irrelevant. I've said earlier that XFS delalloc extents can span
regions that have no page cache state - they don't get reported as
holes by FIEMAP because they are tracked as delalloc. IOWs, like
unwritten extents, you can't rely on delalloc extents to tell you
where the data is in the file.

So, it logically follws that you need to use the SYNC flag for both
unwritten extents and delalloc extents to find out where there data
realy lies by converting them to real, written extents. i.e. the
only extents you can trust contain data from FIEMAP are the real
extents on disk....

Cheers,

Dave.
-- 
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org

  parent reply	other threads:[~2011-04-19 21:08 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110414102608.GA1678@x4.trippels.de>
     [not found] ` <20110414120635.GB1678@x4.trippels.de>
     [not found]   ` <20110414140222.GB1679@x4.trippels.de>
     [not found]     ` <20110414140222.GB1679-tLCgZGx+iJ+kxVt8IV0GqQ@public.gmane.org>
2011-04-14 14:59       ` Files full of zeros with coreutils-8.11 and xfs (FIEMAP related?) Pádraig Brady
     [not found]         ` <4DA70BD3.1070409-V8g9lnOeT5ydJdNcDFJN0w@public.gmane.org>
2011-04-14 15:50           ` Eric Sandeen
     [not found]             ` <4DA717B2.3020305-+82itfer+wXR7s880joybQ@public.gmane.org>
2011-04-14 15:52               ` Pádraig Brady
2011-04-14 15:56                 ` Eric Sandeen
2011-04-14 16:03                   ` Markus Trippelsdorf
2011-04-14 16:14                     ` Eric Sandeen
     [not found]                     ` <20110414160343.GA12787-tLCgZGx+iJ+kxVt8IV0GqQ@public.gmane.org>
2011-04-14 16:21                       ` Yongqiang Yang
     [not found]                         ` <BANLkTimRxvBMp9M7zwiUY_UmmFOY5N58+A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-14 16:28                           ` Markus Trippelsdorf
2011-04-14 16:31                             ` Eric Sandeen
2011-04-14 16:48                               ` Markus Trippelsdorf
2011-04-14 16:49                                 ` Eric Sandeen
2011-04-14 16:04                   ` Yongqiang Yang
2011-04-14 16:10                     ` Yongqiang Yang
     [not found]                       ` <BANLkTimoLeWMJgNFGW+zdeUeJyZ-_+8fMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-05-05 11:29                         ` Pádraig Brady
2011-05-05 11:47                           ` Yongqiang Yang
     [not found]                 ` <4DA7182B.8050409-V8g9lnOeT5ydJdNcDFJN0w@public.gmane.org>
2011-04-14 17:27                   ` Jim Meyering
2011-04-14 19:13                     ` Pádraig Brady
     [not found]                     ` <878vvcspz0.fsf-CybKA8TIZ99x3y/oJEDuiw@public.gmane.org>
2011-04-14 19:39                       ` Jim Meyering
2011-04-14 22:59             ` Dave Chinner
2011-04-14 23:29               ` Pádraig Brady
2011-04-15  0:09                 ` Dave Chinner
2011-04-15  5:01                   ` Andreas Dilger
2011-04-16  0:50                     ` Dave Chinner
2011-04-16  5:11                       ` Andreas Dilger
2011-04-16 12:21                         ` Theodore Tso
2011-04-18  0:40                           ` Dave Chinner
2011-04-18  2:45                             ` Andreas Dilger
2011-04-19  1:58                               ` Yongqiang Yang
     [not found]                                 ` <BANLkTin=WEpSf6ddiOMNMOpCPP-wiEttSw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-19  2:59                                   ` Ted Ts'o
     [not found]                                     ` <20110419025949.GA3030-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2011-04-19  3:05                                       ` Eric Sandeen
     [not found]                                         ` <4DACFBEB.9040909-+82itfer+wXR7s880joybQ@public.gmane.org>
2011-04-21 20:12                                           ` Jim Meyering
2011-04-19  3:30                                     ` Yongqiang Yang
2011-04-19  4:14                                     ` Dave Chinner
2011-04-19  5:27                                     ` Christoph Hellwig
2011-04-19  3:44                                 ` Dave Chinner
2011-04-19  6:53                                   ` Yongqiang Yang
2011-04-19  7:45                                     ` Dave Chinner
2011-04-19  8:11                                       ` Yongqiang Yang
2011-04-19 14:05                                         ` Eric Sandeen
2011-04-19 14:09                                       ` Ted Ts'o
2011-04-19 14:13                                         ` Eric Sandeen
2011-04-19 16:01                                           ` Ted Ts'o
2011-04-20  1:53                                             ` Yongqiang Yang
2011-04-20 15:21                                             ` Christoph Hellwig
2011-04-20 17:21                                               ` Ted Ts'o
     [not found]                                         ` <20110419140909.GD3030-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2011-04-19 21:08                                           ` Dave Chinner [this message]
2011-04-20 15:29                                             ` Christoph Hellwig
2011-04-16  6:05                       ` Yongqiang Yang
2011-04-18  0:35                         ` Dave Chinner
2011-04-15  8:53                   ` Jim Meyering
2011-04-15 17:16                     ` Christoph Hellwig
     [not found]                       ` <20110415171629.GA9088-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-04-15 17:24                         ` Eric Blake
2011-04-15 17:26                           ` Christoph Hellwig
     [not found]                             ` <20110415172603.GA20086-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-04-15 22:28                               ` Andreas Dilger
2011-04-16  0:25                                 ` Dave Chinner
     [not found] ` <20110414102608.GA1678-tLCgZGx+iJ+kxVt8IV0GqQ@public.gmane.org>
2011-04-20 14:39   ` Jim Meyering
     [not found]     ` <87d3khugv1.fsf-CybKA8TIZ99x3y/oJEDuiw@public.gmane.org>
2011-04-21 20:01       ` Jim Meyering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110419210825.GJ23985@dastard \
    --to=david-fqsqvqoi3ljby3ivrkzq2a@public.gmane.org \
    --cc=adilger-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org \
    --cc=coreutils-mXXj517/zsQ@public.gmane.org \
    --cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=markus-xp2qqqlHh3xzoYq+O6RWwA@public.gmane.org \
    --cc=sandeen-+82itfer+wXR7s880joybQ@public.gmane.org \
    --cc=tytso-3s7WtUTddSA@public.gmane.org \
    --cc=xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org \
    --cc=xiaoqiangnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).