From: Ted Ts'o <tytso@mit.edu>
To: Curt Wohlgemuth <curtw@google.com>
Cc: linux-ext4@vger.kernel.org, jim@meyering.net, cmm@us.ibm.com
Subject: Re: [PATCH] ext4: Don't set PageUptodate in ext4_end_bio()
Date: Sun, 1 May 2011 17:56:42 -0400 [thread overview]
Message-ID: <20110501215642.GB2819@thunk.org> (raw)
In-Reply-To: <1303494718-13444-1-git-send-email-curtw@google.com>
On Fri, Apr 22, 2011 at 10:51:58AM -0700, Curt Wohlgemuth wrote:
> In the bio completion routine, we should not be setting
> PageUptodate at all -- it's set at sys_write() time, and is
> unaffected by success/failure of the write to disk.
>
> This can cause a page corruption bug when
>
> block size < page size
>
> if we have only written a single block -- we might end up
> setting the entire PageUptodate, which will cause subsequent
> reads to get bad data.
>
> Signed-off-by: Curt Wohlgemuth <curtw@google.com>
> Reported-by: Jim Meyering <jim@meyering.net>
> Reported-by: Hugh Dickins <hughd@google.com>
> Cc: Mingming Cao <cmm@us.ibm.com>
Thanks, I've added this to the ext4 tree.
- Ted
next prev parent reply other threads:[~2011-05-01 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 17:51 [PATCH] ext4: Don't set PageUptodate in ext4_end_bio() Curt Wohlgemuth
2011-05-01 21:56 ` Ted Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-25 15:38 Curt Wohlgemuth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110501215642.GB2819@thunk.org \
--to=tytso@mit.edu \
--cc=cmm@us.ibm.com \
--cc=curtw@google.com \
--cc=jim@meyering.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).