From: Ted Ts'o <tytso@mit.edu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Ding Dinghua <dingdinghua85@gmail.com>,
Yongqiang Yang <xiaoqiangnk@gmail.com>,
Niraj Kulkarni <kulkarniniraj14@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: Need of revoke mechanism in JBD
Date: Mon, 2 May 2011 10:43:55 -0400 [thread overview]
Message-ID: <20110502144355.GF2819@thunk.org> (raw)
In-Reply-To: <BANLkTimaR0n-YmtBe6xWKCkOc+PoBNa72w@mail.gmail.com>
On Mon, May 02, 2011 at 01:42:48PM +0300, Amir Goldstein wrote:
>
> Clearly, at the time of this talk, revoke code was still on the design table
> and committed_data is not mentioned, so either it was not introduced yet
> or just wasn't in the scope of the talk.
No, the revoke code was already implemented when he gave the talk.
"The way we're doing that in EXT3 is that deleting metadata can
cause a revoke record to be written into the journal. And when you
do the replay of the journal, the very first pass of the journal
recovery, we look for all of the revoke records and make sure that
any data that's been revoked is never, ever replayed. And so that
deals with that particular case."
Stephen gave the talk in July, 2000. Journal support was first
supported in e2fsprogs 1.20 (released May 2000), and we fixed a bug in
the revoke handling in e2fsprogs 1.21 (released June 2000). Data
journalling mode (only) came first, and was working by late 1999;
indeed we couldn't do ordered or writeback journaling at all until we
had support for the revoke handling, for reasons which he explained in
his talk.
- Ted
prev parent reply other threads:[~2011-05-02 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 8:29 Need of revoke mechanism in JBD Niraj Kulkarni
2011-04-26 8:56 ` Yongqiang Yang
2011-04-26 9:23 ` Ding Dinghua
2011-04-26 10:47 ` Niraj Kulkarni
2011-04-26 10:57 ` Amir Goldstein
2011-04-26 17:27 ` Andreas Dilger
2011-04-27 0:52 ` Ding Dinghua
2011-04-26 12:25 ` Ted Ts'o
2011-04-29 19:45 ` Amir Goldstein
2011-04-30 2:06 ` Niraj Kulkarni
2011-05-01 22:28 ` Ted Ts'o
2011-05-02 10:42 ` Amir Goldstein
2011-05-02 14:43 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502144355.GF2819@thunk.org \
--to=tytso@mit.edu \
--cc=amir73il@gmail.com \
--cc=dingdinghua85@gmail.com \
--cc=kulkarniniraj14@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiaoqiangnk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).