From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
Martin_Zielinski@McAfee.com
Subject: Re: [PATCH 2/2] jbd: fix fsync() tid wraparound bug
Date: Mon, 2 May 2011 14:29:45 -0400 [thread overview]
Message-ID: <20110502182945.GG2819@thunk.org> (raw)
In-Reply-To: <20110502150758.GH4556@quack.suse.cz>
On Mon, May 02, 2011 at 05:07:58PM +0200, Jan Kara wrote:
> The patch looks OK in any case. I'll take it in my tree.
Great, thanks.
> It would take
> about 24 days of constant 1000 trans/s load to trigger this. That's a quite
> heavy load but not so unrealistic with today's HW.
True; but one of the reason why I'm not sure I believe that is this
bug is showing up on some Android devices, where (a) 1000 trans/second
*is* a not just a huge load, but almost impossible to believe, and (b)
if we really are doing 2**31 commits, we would be wearing out the
flash storage being used on the Android devices! (And we're seeing a
handful of failures every week from the testers who participate in a
kerneloops-like reporting system.)
So while I would very much like to believe that it's caused by a tid
wrap, I'm worried there is another bug hiding here....
- Ted
next prev parent reply other threads:[~2011-05-02 18:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BCB84D936723884B91E4CC5CA0A7C54AA4F6D082BE@EMEADALEXMB1.corp.nai.org>
2011-04-25 23:14 ` 2.6.32 ext3 assertion j_running_transaction != NULL fails in commit.c Ted Ts'o
2011-04-26 0:23 ` [PATCH 1/2] jbd2: fix fsync() tid wraparound bug Theodore Ts'o
2011-04-26 0:23 ` [PATCH 2/2] jbd: " Theodore Ts'o
2011-04-30 17:17 ` Ted Ts'o
2011-05-02 15:07 ` Jan Kara
2011-05-02 18:29 ` Ted Ts'o [this message]
2011-05-02 19:04 ` Jan Kara
2011-05-02 21:31 ` Ted Ts'o
2011-05-04 14:21 ` Martin_Zielinski
2011-05-04 21:55 ` Jan Kara
2011-05-05 14:11 ` Martin_Zielinski
2011-05-05 15:53 ` Jan Kara
2011-05-05 14:55 ` Martin_Zielinski
2011-05-05 15:43 ` Jan Kara
2011-04-26 9:07 ` 2.6.32 ext3 assertion j_running_transaction != NULL fails in commit.c Martin_Zielinski
2011-04-26 12:23 ` Ted Ts'o
2011-04-26 12:45 ` Martin_Zielinski
2011-04-26 17:20 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502182945.GG2819@thunk.org \
--to=tytso@mit.edu \
--cc=Martin_Zielinski@McAfee.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).