From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Lukas Czerner <lczerner@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, DarkNovaNick@gmail.com,
linux-lvm@redhat.com, linux-ext4@vger.kernel.org
Subject: Re: [dm-devel] do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target]
Date: Wed, 4 May 2011 12:33:17 -0400 [thread overview]
Message-ID: <20110504163317.GA17529@thunk.org> (raw)
In-Reply-To: <4DBACB23.80607@redhat.com>
On Fri, Apr 29, 2011 at 09:28:51AM -0500, Eric Sandeen wrote:
> On 4/29/11 7:29 AM, Christoph Hellwig wrote:
> > FYI, that disable discard on failure seems to be an ext4 special and no
> > one else picked up that stupid idea. If ext4 wants to misbehave for
> > that just let them..
>
> It was my "stupid idea," and I'm ok with reverting it ;)
I think I forgot to send the patch out, but it's been reverted in the
ext4 master branch, commit id: d9f34504e695. It's more than a revert,
actually, since I also dropped error checking for FITRIM. Otherwise
an attempt to use FITRIM would stop after hitting the first dm region
that didn't support discards.
- Ted
next prev parent reply other threads:[~2011-05-04 16:33 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110412234706.GA11244@redhat.com>
[not found] ` <20cf301cbef67d323104a0c2ff52@google.com>
[not found] ` <20110413224025.GA18589@redhat.com>
[not found] ` <20110413234854.GA19793@redhat.com>
[not found] ` <20110426173213.GA19604@redhat.com>
[not found] ` <20110428001912.GA14659@redhat.com>
[not found] ` <20110428075355.GA2190@infradead.org>
2011-04-28 20:59 ` do not disable ext4 discards on first discard failure? [was: Re: dm snapshot: ignore discards issued to the snapshot-origin target] Mike Snitzer
2011-04-28 21:28 ` Eric Sandeen
2011-04-28 22:59 ` [linux-lvm] " Alasdair G Kergon
2011-04-28 23:01 ` Eric Sandeen
2011-04-28 23:11 ` Alasdair G Kergon
2011-04-29 1:12 ` Andreas Dilger
2011-04-29 9:30 ` Lukas Czerner
2011-04-29 12:24 ` [dm-devel] " Alasdair G Kergon
2011-04-29 12:29 ` Christoph Hellwig
2011-04-29 14:28 ` Eric Sandeen
2011-04-29 15:13 ` [linux-lvm] " Ray Morris
2011-05-04 16:33 ` Ted Ts'o [this message]
2011-05-04 16:51 ` Eric Sandeen
2011-05-04 16:57 ` Lukas Czerner
2011-05-04 17:02 ` Lukas Czerner
2011-05-02 7:16 ` Lukas Czerner
2011-05-02 8:13 ` Alasdair G Kergon
2011-05-02 8:19 ` Christoph Hellwig
2011-05-02 10:24 ` Lukas Czerner
2011-05-02 12:48 ` Mike Snitzer
2011-05-02 13:05 ` Lukas Czerner
2011-05-02 14:47 ` Eric Sandeen
2011-05-02 14:48 ` Christoph Hellwig
2011-05-02 14:58 ` Lukas Czerner
2011-05-02 13:48 ` [dm-devel] " Martin K. Petersen
2011-05-02 14:20 ` Martin K. Petersen
2011-05-02 14:39 ` [dm-devel] " Lukas Czerner
2011-05-02 14:50 ` Martin K. Petersen
2011-05-02 14:58 ` Mike Snitzer
2011-05-02 16:58 ` [dm-devel] " Martin K. Petersen
2011-05-03 8:57 ` Lukas Czerner
2011-05-04 15:10 ` Martin K. Petersen
2011-05-04 16:02 ` Mike Snitzer
2011-05-04 16:50 ` Martin K. Petersen
2011-05-04 18:03 ` Mike Snitzer
2011-05-04 17:10 ` [dm-devel] " Lukas Czerner
2011-05-04 17:32 ` Martin K. Petersen
2011-05-04 17:35 ` Lukas Czerner
2011-05-18 12:16 ` Mike Snitzer
2011-05-18 12:52 ` Mike Snitzer
2011-05-04 15:16 ` [dm-devel] " Martin K. Petersen
2011-05-04 16:12 ` Lukas Czerner
2011-05-05 8:33 ` Karel Zak
2011-05-05 10:48 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504163317.GA17529@thunk.org \
--to=tytso@mit.edu \
--cc=DarkNovaNick@gmail.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-lvm@redhat.com \
--cc=sandeen@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).