From: Ted Ts'o <tytso@mit.edu>
To: Tao Ma <tm@tao.ma>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Use EXT4FS_DEBUG instead of EXT4_DEBUG in fsync.c
Date: Sun, 8 May 2011 21:55:06 -0400 [thread overview]
Message-ID: <20110509015506.GD4138@thunk.org> (raw)
In-Reply-To: <1301326873-9551-1-git-send-email-tm@tao.ma>
On Mon, Mar 28, 2011 at 11:41:12PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
>
> We have EXT4FS_DEBUG for some old debug and CONFIG_EXT4_DEBUG
> for the new mballoc debug, but there isn't any EXT4_DEBUG.
>
> As CONFIG_EXT4_DEBUG seems to be only used in mballoc, use
> EXT4FS_DEBUG in fsync.c.
>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
It doesn't really matter; although I'm including this patch in the
ext4 tree for consistency's sake. The whole point of the #ifdef's is
to disable the debugging code. In general you don't want to enable
all of the code protected by EXT4FS_DEBUG at the same time.
- Ted
prev parent reply other threads:[~2011-05-09 1:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 15:41 [PATCH] ext4: Use EXT4FS_DEBUG instead of EXT4_DEBUG in fsync.c Tao Ma
2011-03-28 15:41 ` [PATCH] ext4: Use s_inodes_per_block directly in __ext4_get_inode_loc Tao Ma
2011-05-09 1:56 ` Ted Ts'o
2011-05-09 1:55 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110509015506.GD4138@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).