linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Arcangeli <aarcange@redhat.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	Dave Jones <davej@redhat.com>, Mel Gorman <mgorman@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Colin King <colin.king@canonical.com>,
	Raghavendra D Prabhu <raghu.prabhu13@gmail.com>,
	Jan Kara <jack@suse.cz>, Chris Mason <chris.mason@oracle.com>,
	Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 3/3] mm: slub: Default slub_max_order to 0
Date: Thu, 12 May 2011 20:00:18 +0200	[thread overview]
Message-ID: <20110512180018.GN11579@random.random> (raw)
In-Reply-To: <alpine.DEB.2.00.1105121232110.28493@router.home>

On Thu, May 12, 2011 at 12:38:34PM -0500, Christoph Lameter wrote:
> I dont think that will change much since huge pages are at MAX_ORDER size.
> Either you can get them or not. The challenge with the small order
> allocations is that they require contiguous memory. Compaction is likely
> not as effective as the prior mechanism that did opportunistic reclaim of
> neighboring pages.

THP requires contiguous pages too, the issue is similar, and worse
with THP, but THP enables compaction by default, likely this only
happens with compaction off. We've really to differentiate between
compaction on and off, it makes world of difference (a THP enabled
kernel with compaction off, also runs into swap storms and temporary
hangs all the time, it's probably the same issue of SLUB=y
COMPACTION=n). At least THP didn't activate kswapd, kswapd running
lumpy too makes things worse as it'll probably keep running in the
background after the direct reclaim fails.

The original reports talks about kerenls with SLUB=y and
COMPACTION=n. Not sure if anybody is having trouble with SLUB=y
COMPACTION=y...

Compaction is more effective than the prior mechanism too (prior
mechanism is lumpy reclaim) and it doesn't cause VM disruptions that
ignore all referenced information and takes down anything it finds in
the way.

I think when COMPACTION=n, lumpy either should go away, or only be
activated by __GFP_REPEAT so that only hugetlbfs makes use of
it. Increasing nr_hugepages is ok to halt the system for a while but
when all allocations are doing that, system becomes unusable, kind of
livelocked.

BTW, it comes to mind in patch 2, SLUB should clear __GFP_REPEAT too
(not only __GFP_NOFAIL). Clearing __GFP_WAIT may be worth it or not
with COMPACTION=y, definitely good idea to clear __GFP_WAIT unless
lumpy is restricted to __GFP_REPEAT|__GFP_NOFAIL.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-05-12 18:00 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-11 15:29 [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations Mel Gorman
2011-05-11 15:29 ` [PATCH 1/3] mm: slub: Do not wake kswapd for SLUBs speculative " Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 15:29 ` [PATCH 2/3] mm: slub: Do not take expensive steps " Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 21:10     ` Mel Gorman
2011-05-12 17:25       ` Andrea Arcangeli
2011-05-11 15:29 ` [PATCH 3/3] mm: slub: Default slub_max_order to 0 Mel Gorman
2011-05-11 20:38   ` David Rientjes
2011-05-11 20:53     ` James Bottomley
2011-05-11 21:09     ` Mel Gorman
2011-05-11 22:27       ` David Rientjes
2011-05-13 10:14         ` Mel Gorman
2011-05-12 17:36     ` Andrea Arcangeli
2011-05-16 21:03       ` David Rientjes
2011-05-17  9:48         ` Mel Gorman
2011-05-17 19:25           ` David Rientjes
2011-05-12 14:43   ` Christoph Lameter
2011-05-12 15:15     ` James Bottomley
2011-05-12 15:27       ` Christoph Lameter
2011-05-12 15:43         ` James Bottomley
2011-05-12 15:46           ` Dave Jones
2011-05-12 16:00             ` James Bottomley
2011-05-12 16:08               ` Dave Jones
2011-05-12 16:27               ` Christoph Lameter
2011-05-12 16:30                 ` James Bottomley
2011-05-12 16:48                   ` Christoph Lameter
2011-05-12 17:46                     ` Andrea Arcangeli
2011-05-12 18:00                       ` Christoph Lameter
2011-05-12 18:18                         ` Andrea Arcangeli
2011-05-12 17:06                   ` Pekka Enberg
2011-05-12 17:11                     ` Pekka Enberg
2011-05-12 17:38                       ` Christoph Lameter
2011-05-12 18:00                         ` Andrea Arcangeli [this message]
2011-05-13  9:49                           ` Mel Gorman
2011-05-15 16:39                             ` Andrea Arcangeli
2011-05-16  8:42                               ` Mel Gorman
2011-05-12 17:51                       ` Andrea Arcangeli
2011-05-12 18:03                         ` Christoph Lameter
2011-05-12 18:09                           ` Andrea Arcangeli
2011-05-12 18:16                             ` Christoph Lameter
2011-05-12 18:36                       ` James Bottomley
2011-05-12 17:40                 ` Andrea Arcangeli
2011-05-12 15:55           ` Pekka Enberg
2011-05-12 18:37             ` James Bottomley
2011-05-12 18:46               ` Christoph Lameter
2011-05-12 19:21                 ` James Bottomley
2011-05-12 19:44               ` James Bottomley
2011-05-12 20:04                 ` James Bottomley
2011-05-12 20:29                   ` Johannes Weiner
2011-05-12 20:31                     ` Johannes Weiner
2011-05-12 20:31                     ` James Bottomley
2011-05-12 22:04                   ` James Bottomley
2011-05-12 22:15                     ` Johannes Weiner
2011-05-12 22:58                       ` Minchan Kim
2011-05-13  5:39                         ` Minchan Kim
2011-05-13  0:47                       ` James Bottomley
2011-05-13  4:12                         ` James Bottomley
2011-05-13 10:55                         ` Mel Gorman
2011-05-13 14:16                           ` James Bottomley
2011-05-13 10:30                       ` Mel Gorman
2011-05-13  6:16                   ` Pekka Enberg
2011-05-13 10:05                     ` Mel Gorman
2011-05-12 16:01           ` Christoph Lameter
2011-05-12 16:10             ` Eric Dumazet
2011-05-12 17:37               ` Andrew Morton
2011-05-12 15:45         ` Dave Jones
2011-05-11 21:39 ` [PATCH 0/3] Reduce impact to overall system of SLUB using high-order allocations James Bottomley
2011-05-11 22:28   ` David Rientjes
2011-05-11 22:34     ` James Bottomley
2011-05-12 11:13       ` Pekka Enberg
2011-05-12 13:19         ` Mel Gorman
2011-05-12 14:04         ` James Bottomley
2011-05-12 15:53           ` James Bottomley
2011-05-13 11:25             ` Mel Gorman
2011-05-12 18:04       ` Andrea Arcangeli
2011-05-13 11:24         ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512180018.GN11579@random.random \
    --to=aarcange@redhat.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=cl@linux.com \
    --cc=colin.king@canonical.com \
    --cc=davej@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=penberg@kernel.org \
    --cc=raghu.prabhu13@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).