From: Jan Kara <jack@suse.cz>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Theodore Tso <tytso@mit.edu>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext4: fix NULL pointer dereference in ext4_quota_off
Date: Mon, 16 May 2011 12:13:29 +0200 [thread overview]
Message-ID: <20110516101329.GC5344@quack.suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1105161148010.3670@dhcp-27-109.brq.redhat.com>
On Mon 16-05-11 11:49:22, Lukas Czerner wrote:
> On Mon, 16 May 2011, Amir Goldstein wrote:
> > diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> > index fc827bb..2689351 100644
> > --- a/fs/ext4/super.c
> > +++ b/fs/ext4/super.c
> > @@ -4681,6 +4681,9 @@ static int ext4_quota_off(struct super_block
> > *sb, int type)
> > if (test_opt(sb, DELALLOC))
> > sync_filesystem(sb);
> >
> > + if (!inode)
> > + goto out;
>
> Just out of curiosity, why would the quota inode be NULL ?
Because quota is already turned off (we then release all references to
quota file). Just what I don't understand is why in Amir's testing quota is
not turned on before calling quota off. Because when I run the same test, I
don't trigger the issue.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2011-05-16 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-16 9:31 [PATCH] ext4: fix NULL pointer dereference in ext4_quota_off Amir Goldstein
2011-05-16 9:49 ` Lukas Czerner
2011-05-16 10:13 ` Jan Kara [this message]
2011-05-16 10:53 ` Lukas Czerner
2011-05-16 11:03 ` Jan Kara
2011-05-16 10:11 ` Jan Kara
2011-05-16 14:04 ` Ted Ts'o
2011-05-16 14:40 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110516101329.GC5344@quack.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).