From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, sandeen@redhat.com
Subject: Re: [4/4,v2] ext4: fix possible use-after-free ext4_remove_li_request()
Date: Fri, 20 May 2011 14:22:22 -0400 [thread overview]
Message-ID: <20110520182222.GA10378@thunk.org> (raw)
In-Reply-To: <1305890442-16361-4-git-send-email-lczerner@redhat.com>
On Fri, May 20, 2011 at 01:20:42AM -0000, Lukas Czerner wrote:
> We need to take reference to the s_li_request after we take a mutex,
> because it might be freed since then, hence result in accessing old
> already freed memory. Also we should protect the whole
> ext4_remove_li_request() because ext4_li_info might be in the process of
> being freed in ext4_lazyinit_thread().
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
I've merged all four lazyinit patches into the ext4 tree, thanks.
- Ted
prev parent reply other threads:[~2011-05-20 18:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 11:20 [PATCH 1/4 v3] ext4: Use schedule_timeout_interruptible() for waiting in lazyinit thread Lukas Czerner
2011-05-20 11:20 ` [PATCH 2/4 v3] ext4: Remove unnecessary wait_event ext4_run_lazyinit_thread() Lukas Czerner
2011-05-20 11:20 ` [PATCH 3/4 v2] ext4: fix init_itable=n to work as expected for n=0 Lukas Czerner
2011-05-20 11:20 ` [PATCH 4/4 v2] ext4: fix possible use-after-free ext4_remove_li_request() Lukas Czerner
2011-05-20 18:22 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110520182222.GA10378@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).