linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] e2fsprogs: Unify the upper limit of reserved blocks count
@ 2011-04-19  6:11 Kazuya Mio
  2011-06-01  0:11 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Kazuya Mio @ 2011-04-19  6:11 UTC (permalink / raw)
  To: ext4, Theodore Tso

In e2fsprogs, the upper limit of reserved blocks count is a half of
filesystem's blocks count. This patch fixes the incorrect checks of
reserved blocks count.

Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
---
 lib/ext2fs/initialize.c |    2 +-
 misc/tune2fs.c          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ext2fs/initialize.c b/lib/ext2fs/initialize.c
index e1f229b..afefbfd 100644
--- a/lib/ext2fs/initialize.c
+++ b/lib/ext2fs/initialize.c
@@ -192,7 +192,7 @@ errcode_t ext2fs_initialize(const char *name, int flags,
 
 	ext2fs_blocks_count_set(super, ext2fs_blocks_count(param));
 	ext2fs_r_blocks_count_set(super, ext2fs_r_blocks_count(param));
-	if (ext2fs_r_blocks_count(super) >= ext2fs_blocks_count(param)) {
+	if (ext2fs_r_blocks_count(super) > ext2fs_blocks_count(param) / 2) {
 		retval = EXT2_ET_INVALID_ARGUMENT;
 		goto cleanup;
 	}
diff --git a/misc/tune2fs.c b/misc/tune2fs.c
index bcada11..fad86c0 100644
--- a/misc/tune2fs.c
+++ b/misc/tune2fs.c
@@ -1718,7 +1718,7 @@ retry_open:
 			reserved_ratio, ext2fs_r_blocks_count(sb));
 	}
 	if (r_flag) {
-		if (reserved_blocks >= ext2fs_blocks_count(sb)/2) {
+		if (reserved_blocks > ext2fs_blocks_count(sb) / 2) {
 			com_err(program_name, 0,
 				_("reserved blocks count is too big (%llu)"),
 				reserved_blocks);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-01  2:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-19  6:11 [PATCH] e2fsprogs: Unify the upper limit of reserved blocks count Kazuya Mio
2011-06-01  0:11 ` Ted Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).