From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Vivek Goyal <vgoyal@redhat.com>, Ted Ts'o <tytso@mit.edu>,
Dave Chinner <david@fromorbit.com>,
linux-ext4@vger.kernel.org
Subject: Re: Query about DIO/AIO WRITE throttling and ext4 serialization
Date: Fri, 3 Jun 2011 01:00:55 -0400 [thread overview]
Message-ID: <20110603050055.GA6136@infradead.org> (raw)
In-Reply-To: <4DE8555E.7040404@redhat.com>
On Thu, Jun 02, 2011 at 10:30:38PM -0500, Eric Sandeen wrote:
> On 6/2/11 8:02 PM, Christoph Hellwig wrote:
> > On Thu, Jun 02, 2011 at 08:54:03PM -0400, Vivek Goyal wrote:
> >> Just wondering why ext4 and XFS behavior are different and which is a
> >> more appropriate behavior. ext4 does not seem to be waiting for all
> >> pending AIO/DIO to finish while XFS does.
> >
> > They're both wrong. Ext4 completely misses support in fsync or sync
> > to catch pending unwrittent extent conversions, and thus fails to obey
> > the data integrity guarante.
>
> I'm not sure about that.
>
> ext4_sync_file() does ext4_flush_completed_IO() which does:
> Granted, I get easily lost in ext4's codepaths here, which is actually
> why I suggested Vivek pose these questions to the list ;)
You're right it gets fsync right, but the sync still seems to be missing,
which does not just include sync, but also the syncfs system call
and unmount.
next prev parent reply other threads:[~2011-06-03 5:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 21:50 Query about DIO/AIO WRITE throttling and ext4 serialization Vivek Goyal
2011-06-02 1:22 ` Dave Chinner
2011-06-02 14:17 ` Vivek Goyal
2011-06-02 14:36 ` Vivek Goyal
2011-06-02 15:56 ` Vivek Goyal
2011-06-02 23:51 ` Dave Chinner
2011-06-03 0:27 ` Vivek Goyal
2011-06-03 0:43 ` Ted Ts'o
2011-06-03 0:54 ` Vivek Goyal
2011-06-03 1:02 ` Christoph Hellwig
2011-06-03 1:28 ` Vivek Goyal
2011-06-03 1:33 ` Vivek Goyal
2011-06-09 13:09 ` Christoph Hellwig
2011-06-03 3:30 ` Eric Sandeen
2011-06-03 5:00 ` Christoph Hellwig [this message]
2011-06-03 1:11 ` Ted Ts'o
2011-06-02 23:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603050055.GA6136@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).