From: Ted Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: Fix oops in jbd2_journal_remove_journal_head()
Date: Sun, 12 Jun 2011 17:41:13 -0400 [thread overview]
Message-ID: <20110612214113.GD2662@thunk.org> (raw)
In-Reply-To: <20110608193142.GH5361@quack.suse.cz>
On Wed, Jun 08, 2011 at 09:31:42PM +0200, Jan Kara wrote:
> On Mon 06-06-11 10:16:30, Ted Tso wrote:
> > On Mon, May 30, 2011 at 05:12:58PM +0200, Jan Kara wrote:
> > > /*
> > > - * For the unlocked version of this call, also make sure that any
> > > - * hanging journal_head is cleaned up if necessary.
> > > + * For the unlocked version of this call, also drop buffer_head reference.
> > > *
> > > * __jbd2_journal_refile_buffer is usually called as part of a single locked
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > Doesn't this paragraph refer to jbd2_journal_refile_buffer(), not
> > __jbd2_journal_refile_buffer()? Or am I missing something?
> Hmm, the comment seems to be wrong. The comment about buffer_head
> reference does not apply anymore. I'll fix that.
Are you going to be sending me a new version of this patch with this
comment fixed? Or should I just remove it?
Thanks,
- Ted
next prev parent reply other threads:[~2011-06-12 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 15:12 [PATCH] jbd2: Fix oops in jbd2_journal_remove_journal_head() Jan Kara
2011-06-06 14:16 ` Ted Ts'o
2011-06-08 14:09 ` Ted Ts'o
2011-06-08 19:31 ` Jan Kara
2011-06-12 21:41 ` Ted Ts'o [this message]
2011-06-13 14:10 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110612214113.GD2662@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).