From: Andrew Morton <akpm@linux-foundation.org>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: jack@suse.cz, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd: Make jbd transactions come from its own cache.
Date: Mon, 13 Jun 2011 16:41:21 -0700 [thread overview]
Message-ID: <20110613164121.d2ca952e.akpm@linux-foundation.org> (raw)
In-Reply-To: <1307784961-1485-1-git-send-email-mkatiyar@gmail.com>
On Sat, 11 Jun 2011 02:36:01 -0700
Manish Katiyar <mkatiyar@gmail.com> wrote:
> Allocate a slab cache for jbd transaction allocations. It may help to test
> various memory failure scenarios.
This doesn't seem terribly useful to me. That's truly ancient code and
the change rate is really low. If there were problem in there then
we'd already know about them. And the allocation frequency for these
objects is very low.
If you had some deeper reason for making this change, please describe
it. For example, were you chasing some bug?
> +static int journal_init_transaction_cache(void)
> +{
> + J_ASSERT(jbd_transaction_cache == NULL);
> + jbd_transaction_cache = kmem_cache_create("jbd_transaction",
> + sizeof(transaction_t),
> + 0, 0, NULL);
We have a KMEM_CACHE helper macro for this. It proved useful at the
time, when we were changing the kmem_cache_create() arguments fairly
often. It's less useful now.
next prev parent reply other threads:[~2011-06-13 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-11 9:36 [PATCH] jbd: Make jbd transactions come from its own cache Manish Katiyar
2011-06-13 23:41 ` Andrew Morton [this message]
2011-06-14 0:02 ` Manish Katiyar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613164121.d2ca952e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=mkatiyar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).