From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Commit 94968e74 breaks f_lotsbad
Date: Sun, 19 Jun 2011 21:58:01 -0400 [thread overview]
Message-ID: <20110620015801.GB32133@thunk.org> (raw)
In-Reply-To: <418F4E42-50E6-4CAA-B6F5-CA59B17E84C0@whamcloud.com>
On Fri, Jun 17, 2011 at 12:28:01AM -0600, Andreas Dilger wrote:
> Ted,
> I was going to send some more fixes, but it looks like your commit
> 94968e74 "libext2fs: teach bitmap functions about bigalloc/cluster"
> breaks the "f_lotsbad" test, which I found via git bisect and verified
> is the offending commit:
The problem was a bug in lib/ext2fs/Makefile.in; the $(SRCS) macro
included "$(srcdir)/blkmap64_ba.o" (note ".o" instead of ".o"; Oops.)
As a result we didn't have a dependency for blkmap64_ba.c in the
Makefile, and so blkmap64_ba.o wasn't getting regenerated when
bmap64.h changed. You can fix it by rm'ing blkmap64_ba.o and then
rebuilding. I'll fixed the Makefile.in, rerun "make depend", and then
check in a fix.
Regards,
- Ted
next prev parent reply other threads:[~2011-06-20 1:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 6:28 Commit 94968e74 breaks f_lotsbad Andreas Dilger
2011-06-20 1:58 ` Ted Ts'o [this message]
2011-06-28 5:16 ` Andreas Dilger
2011-06-28 14:23 ` Ted Ts'o
2011-06-29 7:09 ` Andreas Dilger
2011-08-10 19:07 ` [PATCH] libext2fs: copy cluster_bits in ext2fs_copy_generic_bmap Eric Sandeen
2011-08-11 1:50 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110620015801.GB32133@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).